Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/ferrum/network/intercepted_request.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@ def navigation_request?
@params["isNavigationRequest"]
end

def match?(regexp)
!!url.match(regexp)
def match?(pattern)
case url
when pattern
true
else
false
end
end

def respond(**options)
Expand Down
24 changes: 23 additions & 1 deletion spec/network/intercepted_request_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,27 @@
# frozen_string_literal: true

describe Ferrum::Network::InterceptedRequest do
skip
subject(:request) { described_class.new(nil, params) }

let(:url) { "https://example.com/img/pattern.svg?1" }
let(:params) do
{
"requestId" => "interception-id",
"request" => { "url" => url }
}
end

describe "#match?" do
it "matches regular expressions" do
expect(request.match?(/pattern\.svg\?\d/)).to be(true)
end

it "matches exact strings" do
expect(request.match?("https://example.com/img/pattern.svg?1")).to be(true)
end

it "does not treat string patterns as regular expressions" do
expect(request.match?("pattern.svg?1")).to be(false)
end
end
end
Loading