revert(0133): remove write-amplification probe — BE owns the guardrail - #157
Merged
Conversation
…nfra alarm) After the BE response the approach changed: instead of a prices-owned write-amplification probe, BE will cover this at the shared-infra layer with a transfer-cost alarm they own. That meets the task goal (the next amplification hits an alarm, not a bill) without a prices-owned probe or the system.part_log grant that the prices CH users (XML-managed in BE's users_xml, readonly to SQL) could not receive without a BE services.xml change. PR #156's code is reverted in this branch (unused). Task marked completed and moved to archive with a Resolution note; the design + measured threshold are retained for the record.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5add848) — the prices-ownedwrite-amplification-probeLambda +Prices/Ingestmetric + CloudWatch alarm. The code is unused and removed fromdevelop.prices_readerto readsystem.part_log, but the prices CH users are XML-managed in BE'susers_xml(readonly to SQL) — a SQLGRANTfails (Code 495 ACCESS_STORAGE_READONLY) and would require a BEservices.xmlchange. On raising it, BE chose to cover this at the shared-infra layer instead: a transfer-cost alarm they own. That meets the 0133 goal (the next amplification hits an alarm, not a bill) without a prices-owned probe.part_logmeasurement) are retained in the archived task for the record.Verification
cargo check+ infranx buildpass after the revert (no dangling references to the removed crate/wiring).