fix: don't drop networkVolume and networkVolumeId in pod get - #322
Open
ajpower wants to merge 1 commit into
Open
fix: don't drop networkVolume and networkVolumeId in pod get#322ajpower wants to merge 1 commit into
ajpower wants to merge 1 commit into
Conversation
ajpower
marked this pull request as ready for review
July 31, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runpodctl pod get $pod --include-network-volumedoes not actually return network volume info despite passing the required params to the underlying REST API. The root cause is that thePodstruct is missing these fields, so they are discarded upon deserialization. This PR adds the missing fields and closes #291.Testing
I created a pod
nsr02fbf61si3nwith a network volume attached. Without the change,runpodctl pod get nsr02fbf61si3n --include-network-volume | jq '.networkVolume'returnsnull. With the change,bin/runpodctl pod get nsr02fbf61si3n --include-network-volume | jq '.networkVolume'returns{ "dataCenterId": "EU-CZ-1", "id": "niq6cdm1yy", "name": "principal_pink_tern", "size": 10 }Note that with the change,
pod getalways returns anetworkVolumeId(if a network volume is present) whether--include-network-volumeis passed or not. I believe this is the desired behaviour since the inclusion of thenetworkVolumeIdcomes for free.Related issue
While investigating this issue, I discovered another bug:
uptimeSecondsseems to always be zero. Podnsr02fbf61si3nhas an uptime of over an hour, yetrunpodctl pod get nsr02fbf61si3n | jq '.uptimeSeconds'returns0. I believe the root cause is that the GraphQL API returns{ "uptimeSeconds": 0, "runtime": { "uptimeInSeconds": 4026 } }but the CLI takes
uptimeSecondsinstead ofruntime.uptimeInSeconds.