Skip to content

feat: add host parameter to http::server::listen #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruoka merged 1 commit into from
Jul 15, 2026
Merged

feat: add host parameter to http::server::listen #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions net/net-http_server.c++m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,15 +199,21 @@ public:
}

void listen(std::string_view service_or_port = "http")
{
listen("0.0.0.0"sv, service_or_port);
}

void listen(std::string_view host, std::string_view service_or_port)
{
using namespace std::string_view_literals;
m_stop.store(false);
net::slog << net::notice("HTTP_SERVER_START") << "starting up at " << service_or_port
net::slog << net::notice("HTTP_SERVER_START") << "starting up at " << host << ":" << service_or_port
<< std::pair{"addr"sv, host}
<< std::pair{"port"sv, service_or_port}
<< net::flush;
try
{
auto endpoint = net::acceptor{"0.0.0.0", service_or_port};
auto endpoint = net::acceptor{host, service_or_port};
auto check_timeout = m_timeout.count() ? m_timeout : std::chrono::seconds{1};
endpoint.timeout(std::chrono::milliseconds{check_timeout.count() * 1000});
net::slog << net::notice("HTTP_SERVER_READY") << "started up at " << endpoint.host() << ":" << endpoint.service_or_port()
Expand Down
Loading