Skip to content

Replace tempdir with tempfile - #176

Merged
tgross35 merged 1 commit into
rust-lang:masterfrom
alexanderkjall:replace-tempdir-with-tempfile
Sep 17, 2025
Merged

Replace tempdir with tempfile#176
tgross35 merged 1 commit into
rust-lang:masterfrom
alexanderkjall:replace-tempdir-with-tempfile

Conversation

@alexanderkjall

Copy link
Copy Markdown
Contributor

as the tempdir crate has been superseded by tempfile.

Now that MSRV was raised in #172 we can replace tempdir with tempfile.

@alexanderkjall

Copy link
Copy Markdown
Contributor Author

So this problem seem to be that a sub-dependency of tempdir (that have MSRV 1.63) seem to have a MSRV of 1.65.

As far as I know that isn't really solvable without hand editing a Cargo.lock file, and that seems a bit extreme. If anyone have a suggesion on how to solve this I'm happy to try it out :)

@tgross35

Copy link
Copy Markdown
Contributor

The 1.63 test jobs can be switched to check-only, so our dev dependencies aren't limited by the MSRV.

@alexanderkjall

alexanderkjall commented Sep 14, 2025

Copy link
Copy Markdown
Contributor Author

I'm not an expert at build jobs, should I delete this line:

https://github.com/rust-lang/glob/blob/master/.github/workflows/rust.yml#L23

since the MSRV build check is done here:

https://github.com/rust-lang/glob/blob/master/.github/workflows/rust.yml#L71

?

@tgross35

Copy link
Copy Markdown
Contributor

Rather than deleting the first line, just bump it to whatever the MSRV for tempdir / its deps is. No harm in keeping a reasonably old test here, even though we have the MSRV check.

(Would be nice if the MSRV check covered multiple platforms, but that can happen separately)

@alexanderkjall
alexanderkjall force-pushed the replace-tempdir-with-tempfile branch from 964a9bc to f70cbe9 Compare September 16, 2025 12:15
@alexanderkjall
alexanderkjall force-pushed the replace-tempdir-with-tempfile branch from f70cbe9 to f2be6c3 Compare September 16, 2025 13:49
@alexanderkjall

Copy link
Copy Markdown
Contributor Author

Done, I had to dump it all the way up to .71 due to a windows-only dep. Thanks for the guidance.

@tgross35 tgross35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35
tgross35 merged commit b5fe5a1 into rust-lang:master Sep 17, 2025
17 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 17, 2025
@alexanderkjall
alexanderkjall deleted the replace-tempdir-with-tempfile branch September 18, 2025 09:52
@RalfJung

Copy link
Copy Markdown
Member

Would be nice to get a release with this -- glob is currently the biggest remaining user of tempdir. :)

@tgross35

Copy link
Copy Markdown
Contributor

It's just a dev dep right? Doesn't hurt to get out of the graph, kicked off #177.

@tgross35

Copy link
Copy Markdown
Contributor

https://github.com/rust-lang/glob/releases/tag/v0.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants