bsd: round out BPF bindings on apple and freebsd#5235
Open
sbogomolov wants to merge 2 commits into
Open
Conversation
rustbot
added
S-waiting-on-review
stable-nominated
Contributor
Author
|
Could someone please re-run the |
Contributor
|
The PR template asks for links to source headers. Could you please include them? |
sbogomolov
force-pushed
the
bsd-bpf-bindings
branch
5 times, most recently
from
646c595 to
cf248c1
Compare
Contributor
Author
|
@tgross35 I've addressed your comment and also moved everything under |
sbogomolov
force-pushed
the
bsd-bpf-bindings
branch
from
cf248c1 to
8772c73
Compare
apple was missing the two bpf structs; freebsd was missing the DLT_* link types.
sbogomolov
force-pushed
the
bsd-bpf-bindings
branch
from
8772c73 to
404e3a1
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the BPF bindings match across Apple and FreeBSD: add
bpf_programandbpf_insnon Apple (FreeBSD already has them), and theDLT_*link-layer types on FreeBSD/DragonFly (Apple already has them).Sources
Apple
bpf_program/bpf_insn(net/bpf.h):FreeBSD
DLT_*(net/dlt.h):Checklist
libc-test/semverhave been updated*LASTor*MAXare includedcd libc-test && cargo test --target mytarget)