Skip to content

Bump railroad-dependency#2305

Merged
ehuss merged 1 commit into
rust-lang:masterfrom
lukaslueg:railroad37
Jul 6, 2026
Merged

Bump railroad-dependency#2305
ehuss merged 1 commit into
rust-lang:masterfrom
lukaslueg:railroad37

Conversation

@lukaslueg

@lukaslueg lukaslueg commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This would bump the railroad-dependency - used in mdbook-spec to render the syntax-diagrams - to the current version. Changes made to railroad include geometry correctness fixes, user-defined text escaping into the surrounding markup (should not be that much of a problem here), exponential runtime with deeply nested structures (also, since the SVGs are pre-rendered, not much of a problem), and addition of new Node-type which renders many-alternatives in a more space-friendly manner. This PR also changes the rendering of ExpressionKind::Alt and ExpressionKind::Charset to use this new Node-type to limit the vertical expanse in some cases.

Please be aware that some code-changes made in 0.3.2...0.3.7 were made with assistance of an LLM, especially around getting the geometry-calculations correct for caching. I'm not sure how to interpret the LLM-policy around LLMs usage seeping in due to tooling dependencies. I'd be fine with closing this PR and/or comment-fixing the dependency to the current version, in case you want to reject this.

1_before 1_after 3_before 3_after

@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Jul 4, 2026

@ehuss ehuss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehuss ehuss added this pull request to the merge queue Jul 6, 2026
Merged via the queue into rust-lang:master with commit 18d5a01 Jul 6, 2026
6 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Jul 6, 2026
@lukaslueg lukaslueg deleted the railroad37 branch July 6, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants