internal: Cleanup code for old Rust versions - #22914
Merged
ChayimFriedman2 merged 6 commits intoJul 26, 2026
Merged
Conversation
We don't support them now since rust-lang#22784.
It was replaced with an intrinsic in rust-lang/rust#135046, released in 1.86.0. And add MIR eval support for the intrinsic.
Required since 1.88.0.
Renamed to `align_of[_val]()` in 1.89.0.
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Jul 26, 2026
Member
|
That bump might've been a bit too aggressive by us as 1.94 is only from march. |
Contributor
Author
|
Maybe, but I'm actually quite happy about it. It lets us cleanup a lot of code. Since Rust 1.94.0 was released more than 4 months have passed. If you have a legitimate reason to use such old version (and remember we only officially support the last version), you can very well downgrade your r-a. I believe most people using this toolchain just didn't see a reason to upgrade, so we gave them it 😸 |
Member
|
Yea, in this case the code we get rid of is nice. I am fine with merging either way (since otherwise we'd need to revert some PRs anyways), just something to note down. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That we no longer support after #22876.
Reviewing commit-by-commit is recommended.