Fix the swapped arguments in redundant_closure's late-bound region check#17455
Open
shulaoda wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-community-reviews
Collaborator
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
Lintcheck changes for 9cb7746
This comment will be updated if you push new changes |
shulaoda
force-pushed
the
07-26-fix_the_swapped_arguments_in_redundant_closure_s_late-bound_region_check
branch
from
July 25, 2026 23:26
ff1ae6a to
9cb7746
Compare
CommanderStorm
approved these changes
Jul 26, 2026
| return true; | ||
| } | ||
| for (from_arg, to_arg) in to_subs.iter().zip(from_subs) { | ||
| for (from_arg, to_arg) in from_subs.iter().zip(to_subs) { |
There was a problem hiding this comment.
lol. Having a lint specifically for this kind of from_* <-> to_* bug might be nice..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14215
redundant_closureonly reduces|x| f(x)tofwhen both signatures agree on which regions are late-bound, because rustc cannot late bind an early-bound region. The helper that compares a type's generic arguments zipped the two lists in the wrong order, inverting the directionalcheck_regionso that the case it exists to reject was let through. Only ADTs were affected, since a region held directly, as in&'a u32, takes thety::Refarm. So for a bound likeFnOnce(&mut Guard<S>)the lint offered a machine-applicable rewrite that fails to compile withimplementation of FnOnce is not general enough.This zips them in the same order as the call site and the rest of the function.
Correcting the direction also fixes the opposite error, where a safe rewrite was rejected. Four such closures in clippy's own source are now caught by
redundant_closure_for_method_calls, so this reduces them as well to keep dogfood passing.changelog: [
redundant_closure]: don't suggest a non-compiling rewrite when an early-bound region sits inside an ADT