Skip to content

external-ci-runners: consistent headers#1084

Merged
marcoieni merged 1 commit into
rust-lang:masterfrom
RalfJung:external-ci-runners
Jul 24, 2026
Merged

external-ci-runners: consistent headers#1084
marcoieni merged 1 commit into
rust-lang:masterfrom
RalfJung:external-ci-runners

Conversation

@RalfJung

@RalfJung RalfJung commented Jul 23, 2026

Copy link
Copy Markdown
Member

The other ones below use level 2 headers so let's do the same here.

Rendered

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 23, 2026
@rustbot

rustbot commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

r? @ubiratansoares

rustbot has assigned @ubiratansoares.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: infra
  • infra expanded to 8 candidates
  • Random selection from 8 candidates

- Zulip: [Aelin](https://rust-lang.zulipchat.com/#user/338253)
- Email: `aelin@postmarketos.org` (faster response)

### `ubuntu-2X.04-riscv`

@RalfJung RalfJung Jul 23, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu-2X.04-riscv is not a target name so it does not fit the pattern. I took a guess at what the target may be.
Cc @marcoieni

View changes since the review

Comment thread src/infra/docs/external-ci-runners.md Outdated
Comment thread src/infra/docs/external-ci-runners.md Outdated
Comment on lines 72 to 78

@marcoieni marcoieni Jul 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then these should be #### 🙈

View changes since the review

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be impossible to tell apart.^^ Especially with the mdbook rendering it's already hart to tell apart lvl2 from lvl3, just look at https://forge.rust-lang.org/infra/docs/external-ci-runners.html

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made these here not headers at all, and downgraded the others to lvl3. With GH markdown rendering it looks good I think, not sure what it'll look like with mdbook.

@RalfJung
RalfJung force-pushed the external-ci-runners branch from 4b0a675 to d267252 Compare July 23, 2026 15:31
@marcoieni
marcoieni merged commit d7c42ce into rust-lang:master Jul 24, 2026
1 check passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants