Skip to content

Migrate rustc_metadata to SessionDiagnostics - #100928

Merged
bors merged 8 commits into
rust-lang:masterfrom
CleanCut:rustc_metadata_diagnostics
Sep 3, 2022
Merged

Migrate rustc_metadata to SessionDiagnostics#100928
bors merged 8 commits into
rust-lang:masterfrom
CleanCut:rustc_metadata_diagnostics

Conversation

@CleanCut

@CleanCut CleanCut commented Aug 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Migrate rustc_metadata to SessionDiagnostics.

Part of #100717

@rust-highfive

rust-highfive commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 23, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2022
@CleanCut CleanCut mentioned this pull request Aug 23, 2022
Open
84 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lcnr

lcnr commented Aug 24, 2022

Copy link
Copy Markdown
Contributor

r? diagnostics

@rust-highfive rust-highfive assigned estebank and unassigned lcnr Aug 24, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@CleanCut
CleanCut marked this pull request as ready for review August 24, 2022 23:21
@rustbot

rustbot commented Aug 24, 2022

Copy link
Copy Markdown
Collaborator

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

CleanCut
CleanCut commented Aug 24, 2022
View reviewed changes
Comment thread compiler/rustc_metadata/src/locator.rs Outdated
CleanCut
CleanCut commented Aug 24, 2022
View reviewed changes
Comment thread compiler/rustc_metadata/src/locator.rs Outdated
davidtwco
davidtwco requested changes Aug 25, 2022
View reviewed changes

@davidtwco davidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start. I think it would be good to try and use the original types in the diagnostic structs as much as possible, like Symbol and PathBuf and io::Error, because then the struct captures the actual error better.

Comment thread compiler/rustc_metadata/src/creader.rs Outdated
Comment thread compiler/rustc_metadata/src/dependency_format.rs Outdated
Comment thread compiler/rustc_metadata/src/errors.rs Outdated
Comment thread compiler/rustc_metadata/src/fs.rs Outdated
Comment thread compiler/rustc_metadata/src/errors.rs Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@CleanCut

CleanCut commented Aug 26, 2022

Copy link
Copy Markdown
Contributor Author

This is a great start. I think it would be good to try and use the original types in the diagnostic structs as much as possible, like Symbol and PathBuf and io::Error, because then the struct captures the actual error better.

Ah, that's a much better way to do it. Now I know.

✅ Done.

@CleanCut

This comment was marked as resolved.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@CleanCut

CleanCut commented Aug 26, 2022

Copy link
Copy Markdown
Contributor Author

✅ All feedback addressed. Ready for re-review.

@bors

This comment was marked as resolved.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@davidtwco

davidtwco commented Aug 30, 2022

Copy link
Copy Markdown
Member

This is great, do you think you could squash some of the commits? I don't mind if there are some that show the logical progression of the changes but ones that just fix earlier commits don't add much :)

@CleanCut

CleanCut commented Aug 30, 2022

Copy link
Copy Markdown
Contributor Author

@davidtwco I squashed a bunch! How does that look? Should I squash some more?

@bors

bors commented Sep 1, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 30adfd6 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 1, 2022
@Dylan-DPC
Rollup merge of rust-lang#100928 - CleanCut:rustc_metadata_diagnostic…
1116b4d 
…s, r=davidtwco

Migrate rustc_metadata to SessionDiagnostics

Migrate rustc_metadata to SessionDiagnostics.

Part of rust-lang#100717
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 1, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#100928 - CleanCut:rustc_metadata_diagnostic…
f0bbb83 
…s, r=davidtwco

Migrate rustc_metadata to SessionDiagnostics

Migrate rustc_metadata to SessionDiagnostics.

Part of rust-lang#100717
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#100928 - CleanCut:rustc_metadata_diagnostic…
f8f0df6 
…s, r=davidtwco

Migrate rustc_metadata to SessionDiagnostics

Migrate rustc_metadata to SessionDiagnostics.

Part of rust-lang#100717
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#100928 - CleanCut:rustc_metadata_diagnostic…
19f3a31 
…s, r=davidtwco

Migrate rustc_metadata to SessionDiagnostics

Migrate rustc_metadata to SessionDiagnostics.

Part of rust-lang#100717
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#100928 - CleanCut:rustc_metadata_diagnostic…
4c05e77 
…s, r=davidtwco

Migrate rustc_metadata to SessionDiagnostics

Migrate rustc_metadata to SessionDiagnostics.

Part of rust-lang#100717
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 2, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#100928 - CleanCut:rustc_metadata_diagnostic…
38ac670 
…s, r=davidtwco

Migrate rustc_metadata to SessionDiagnostics

Migrate rustc_metadata to SessionDiagnostics.

Part of rust-lang#100717
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#100928 - CleanCut:rustc_metadata_diagnostic…
3a60cbd 
…s, r=davidtwco

Migrate rustc_metadata to SessionDiagnostics

Migrate rustc_metadata to SessionDiagnostics.

Part of rust-lang#100717
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 2, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 3, 2022
@matthiaskrgr
Rollup merge of rust-lang#100928 - CleanCut:rustc_metadata_diagnostic…
6395082 
…s, r=davidtwco

Migrate rustc_metadata to SessionDiagnostics

Migrate rustc_metadata to SessionDiagnostics.

Part of rust-lang#100717
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 3, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 3, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2022
@bors
Auto merge of rust-lang#101361 - Dylan-DPC:rollup-xj1syld, r=Dylan-DPC
9208625 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#99736 (Partially stabilize `bound_as_ref` by stabilizing `Bound::as_ref`)
 - rust-lang#100928 (Migrate rustc_metadata to SessionDiagnostics)
 - rust-lang#101217 ([drop tracking] Use parent expression for scope, not parent node )
 - rust-lang#101325 (Windows RNG: Use `BCRYPT_RNG_ALG_HANDLE` by default)
 - rust-lang#101330 (Fix `std::collections::HashSet::drain` documentation)
 - rust-lang#101338 (Fix unsupported syntax in .manifest file)
 - rust-lang#101348 (Cleanup css theme)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit a005679 into rust-lang:master Sep 3, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 3, 2022
@CleanCut
CleanCut deleted the rustc_metadata_diagnostics branch September 3, 2022 16:43
@ehuss ehuss mentioned this pull request Dec 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@estebank estebank

Labels

A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

8 participants

@CleanCut @rust-highfive @rust-log-analyzer @lcnr @rustbot @bors @davidtwco @estebank