Skip to content

Suggest adding missing braces in const block pattern - #130751

Draft
GrigorenkoPV wants to merge 2 commits into
rust-lang:mainfrom
GrigorenkoPV:missing-{-in-const
Draft

Suggest adding missing braces in const block pattern#130751
GrigorenkoPV wants to merge 2 commits into
rust-lang:mainfrom
GrigorenkoPV:missing-{-in-const

Conversation

@GrigorenkoPV

@GrigorenkoPV GrigorenkoPV commented Sep 23, 2024 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Fixes #78168.

Builds upon work done in #78173.

TODO:

@rustbot author

@rustbot

rustbot commented Sep 23, 2024

Copy link
Copy Markdown
Collaborator

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 23, 2024
@bors

bors commented Nov 17, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #133135) made this pull request unmergeable. Please resolve the merge conflicts.

@BoxyUwU BoxyUwU removed their assignment Nov 21, 2024
@BoxyUwU

BoxyUwU commented Nov 21, 2024

Copy link
Copy Markdown
Member

Unasigning myself from review since this hasn't had any activity in two month, is in a draft state and has some merge conflcits. if you continue this work feel free to reassign me or roll a new reviewer

@Dylan-DPC

Dylan-DPC commented Feb 23, 2025

Copy link
Copy Markdown
Member

@GrigorenkoPV does this still need to be a draft? or is this ready for review? if it's the latter then you can mark it as »ready for review« and the next step would be to assign a random reviewer for this. Thanks

@bors

bors commented Apr 22, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #139897) made this pull request unmergeable. Please resolve the merge conflicts.

camelid and others added 2 commits June 20, 2025 00:05
@camelid @GrigorenkoPV
Suggest adding missing braces in const block pattern
70ee7a6 
Previously it would only suggest wrapping the code in braces in regular
expressions; now it does it in patterns too.

This is a squashed rebase of rust-lang#78173
@GrigorenkoPV
Move eating const back into parse_const_block
2d862ac
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2025
@rustbot

rustbot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@bors

bors commented Dec 29, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #150469) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-bors

rust-bors Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #159966) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve error for missing braces in const block

6 participants

@GrigorenkoPV @rustbot @bors @BoxyUwU @Dylan-DPC @camelid