ci: Make the `x86_64-gnu-parallel-frontend` job non-optional by petrochenkov · Pull Request #159833 · rust-lang/rust

petrochenkov · 2026-07-24T11:30:20Z

View all comments

Part of rust-lang/compiler-team#1005.
Closes #118698.

r? @jieyouxu

rustbot · 2026-07-24T11:30:23Z

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

rustbot · 2026-07-24T11:30:25Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

petrochenkov · 2026-07-24T11:35:44Z

There are two additional things about this change.

First, people merging PRs (especially rollups) need to know what to do if some test failures are encountered in this test suite.
What is the best place to post an announcement about this? Something like:

Announcement:

If you see any test failures in tests/ui from the CI job x86_64-gnu-parallel-frontend, please add //@ ignore-parallel-frontend triage to the failing test, even if your PR is otherwise entirely unrelated to parallel compiler or its testing.
In some time people from the parallel rustc working group will triage the failing test, make a tracking issue for it, and try to debug the problem.

Second, is there a way to check whether this job failed when it was optional, and see the failure logs, if any?

Kobzol · 2026-07-24T13:43:54Z

Second, is there a way to check whether this job failed when it was optional, and see the failure logs, if any?

Right now we don't have good tooling for that, sadly. The CI dashboard doesn't show it in top 10 failing jobs. I can create a better Datadog view specific to that job later.

jieyouxu · 2026-07-25T08:45:03Z

First, people merging PRs (especially rollups) need to know what to do if some test failures are encountered in this test suite.
What is the best place to post an announcement about this? Something like:

We can add an announcement to both #t-compiler and #t-infra/announcements

I believe we can also add a doc_url to the job so that when it fails, we can point to a rustc-dev-guide page (if this is applicable), like

rust/src/ci/github-actions/jobs.yml

Line 157 in da86f4d

    
           doc_url: https://rustc-dev-guide.rust-lang.org/tests/codegen-backend-tests/cg_gcc.html

I think that itself would already help a lot. (We can add a r-d-g page in this PR, then we can predict the rustc-dev-guide URL and put that as doc_url in the job.) I can help to x-post to #t-infra/announcements later.

Happy to r+ this with the doc_url, will send the announcement at the same time.

Kobzol · 2026-07-27T08:49:40Z

Hmm, I realized that creating a dashboard wouldn't help you much, because it will be just a chart, without links to the failures.

rustbot · 2026-07-27T14:17:27Z

rustc-dev-guide is developed in its own repository. If possible, consider making this change to rust-lang/rustc-dev-guide instead.

cc @BoxyUwU, @tshepang

rustbot · 2026-07-27T14:17:29Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

petrochenkov · 2026-07-27T14:18:10Z

Added a dev guide entry and a doc_url linking to it.
@rustbot ready

jieyouxu · 2026-07-27T14:32:20Z

X-posted to:

jieyouxu

Thanks
@bors r+ rollup=iffy (just in case)

View changes since this review

rust-bors · 2026-07-27T14:33:39Z

📌 Commit d568afe has been approved by jieyouxu

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

Reason for tree closure: spurious failures

jieyouxu · 2026-07-27T14:33:59Z

Don't need to block merge but:
@bors try jobs=x86_64-gnu-parallel-frontend

ci: Make the `x86_64-gnu-parallel-frontend` job non-optional try-job: x86_64-gnu-parallel-frontend

rust-bors · 2026-07-27T14:41:12Z

💔 Test for 7b3512f failed: CI. Failed job:

try - x86_64-gnu-parallel-frontend (web logs, enhanced plaintext logs)

rust-bors · 2026-07-27T14:51:21Z

⚠️ A new commit 6a194beb64de8e1cfc2596a63353587a50098978 was pushed.

This pull request was unapproved.

petrochenkov · 2026-07-27T14:51:50Z

@bors try jobs=x86_64-gnu-parallel-frontend

ci: Make the `x86_64-gnu-parallel-frontend` job non-optional try-job: x86_64-gnu-parallel-frontend

petrochenkov · 2026-07-27T15:31:08Z

@bors r=jieyouxu

rust-bors · 2026-07-27T15:31:11Z

📌 Commit 6a194be has been approved by jieyouxu

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

Reason for tree closure: spurious failures

JonathanBrouwer · 2026-07-27T15:38:12Z

@bors r-
The parallel-frontend job is currently failing on main, so unless you include a fix for that, this PR will fail
See #160003 (comment)
Caused by this PR #159774 (comment)

rust-bors · 2026-07-27T15:38:16Z

This pull request was unapproved.

View changes since this unapproval

petrochenkov · 2026-07-27T15:42:05Z

Ok, included #160013 into this PR too.

JonathanBrouwer · 2026-07-27T15:43:51Z

Ah I missed that there was a separate PR fixing that, if they both enter the same rollup it should be fine then

JonathanBrouwer · 2026-07-27T15:45:35Z

@bors r=jieyouxu

rust-bors · 2026-07-27T15:45:38Z

📌 Commit 960d0a5 has been approved by jieyouxu

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

Reason for tree closure: spurious failures

rust-bors · 2026-07-27T16:43:02Z

💔 Test for c45c6e5 failed: CI. Failed job:

try - x86_64-gnu-parallel-frontend (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-07-27T16:50:44Z

The job x86_64-gnu-parallel-frontend failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

diff of stderr:

20 LL | |     Self::Item: Baz,
21    | |____________________^
22    = note: ...which again requires coherence checking all impls of trait `Foo`, completing the cycle
- note: cycle used when checking that `<impl at $DIR/next-solver-region-resolution.rs:12:1: 14:20>` is well-formed
-   --> $DIR/next-solver-region-resolution.rs:12:1
+ note: cycle used when checking that `<impl at $DIR/next-solver-region-resolution.rs:18:1: 20:21>` is well-formed
+   --> $DIR/next-solver-region-resolution.rs:18:1
25    |
- LL | / impl<'a, T> Foo for &'a T
+ LL | / impl<'a, T> Foo for &T
27 LL | | where
- LL | |     Self::Item: 'a,
-    | |___________________^
+ LL | |     Self::Item: Baz,
+    | |____________________^
30    = note: for more information, see <https://rustc-dev-guide.rust-lang.org/overview.html#queries> and <https://rustc-dev-guide.rust-lang.org/query.html>
31 
32 error: aborting due to 1 previous error

Note: some mismatched output was normalized before being compared
- note: cycle used when checking that `<impl at /checkout/tests/ui/specialization/min_specialization/next-solver-region-resolution.rs:18:1: 20:21>` is well-formed
-   --> /checkout/tests/ui/specialization/min_specialization/next-solver-region-resolution.rs:18:1
+ note: cycle used when checking that `<impl at $DIR/next-solver-region-resolution.rs:18:1: 20:21>` is well-formed
+   --> $DIR/next-solver-region-resolution.rs:18:1
+ LL | / impl<'a, T> Foo for &T
+ LL | |     Self::Item: Baz,
+    | |____________________^

Compare output by lines enabled, diff by lines:
Expected contains these lines that are not in actual:
   | |___________________^
  --> $DIR/next-solver-region-resolution.rs:12:1
LL | / impl<'a, T> Foo for &'a T
LL | |     Self::Item: 'a,
note: cycle used when checking that `<impl at $DIR/next-solver-region-resolution.rs:12:1: 14:20>` is well-formed
Actual contains these lines that are not in expected:
   | |____________________^
  --> $DIR/next-solver-region-resolution.rs:18:1
LL | / impl<'a, T> Foo for &T
LL | |     Self::Item: Baz,
note: cycle used when checking that `<impl at $DIR/next-solver-region-resolution.rs:18:1: 20:21>` is well-formed

The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args specialization/min_specialization/next-solver-region-resolution.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/specialization/min_specialization/next-solver-region-resolution.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-Zthreads=4" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/specialization/min_specialization/next-solver-region-resolution" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Znext-solver=globally"
stdout: none
--- stderr -------------------------------
error[E0391]: cycle detected when coherence checking all impls of trait `Foo`
##[error]  --> /checkout/tests/ui/specialization/min_specialization/next-solver-region-resolution.rs:6:1
   |
LL | trait Foo { //~ ERROR cycle detected when coherence checking all impls of trait `Foo`
   | ^^^^^^^^^
   |
   = note: ...which requires building specialization graph of trait `Foo`...
note: ...which requires computing whether impls specialize one another...
  --> /checkout/tests/ui/specialization/min_specialization/next-solver-region-resolution.rs:12:1
   |
LL | / impl<'a, T> Foo for &'a T
LL | | where
LL | |     Self::Item: 'a,
   | |___________________^
note: ...which requires computing normalized predicates of `<impl at /checkout/tests/ui/specialization/min_specialization/next-solver-region-resolution.rs:18:1: 20:21>`...
  --> /checkout/tests/ui/specialization/min_specialization/next-solver-region-resolution.rs:18:1
   |
LL | / impl<'a, T> Foo for &T
LL | | where
LL | |     Self::Item: Baz,
   | |____________________^
   = note: ...which again requires coherence checking all impls of trait `Foo`, completing the cycle
note: cycle used when checking that `<impl at /checkout/tests/ui/specialization/min_specialization/next-solver-region-resolution.rs:18:1: 20:21>` is well-formed
  --> /checkout/tests/ui/specialization/min_specialization/next-solver-region-resolution.rs:18:1
   |
LL | / impl<'a, T> Foo for &T
LL | | where
LL | |     Self::Item: Baz,
   | |____________________^
   = note: for more information, see <https://rustc-dev-guide.rust-lang.org/overview.html#queries> and <https://rustc-dev-guide.rust-lang.org/query.html>

error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0391`.
------------------------------------------

Important

For more information how to resolve CI failures of this job, visit this link.

…uwer Rollup of 14 pull requests Successful merges: - #160009 (`rust-analyzer` subtree update) - #159833 (ci: Make the `x86_64-gnu-parallel-frontend` job non-optional) - #158873 (applying `/Brepro` in bootstrap on MSVC and adding a run-make test.) - #159777 (Enforce that we don't generate code for comptime fns) - #159997 (On many bindings with move error, limit the number of `Span`s) - #158205 (fix: defer const normalize in coherence mode) - #159312 (Windows implementation for stdio set/take/replace) - #159772 (Fix lowering of resolved const inference variables) - #159785 (Share _Unwind_Exception definition between native and wasm) - #159968 (Fix the const impl suggestion) - #159974 (Update thinvec to 0.2.19) - #160013 (tests/ui: Ignore one query cycle test in parallel frontend mode) - #160016 (compiletest: do not talk about JSON when the user never sees any) - #160018 (test suite: add ARM case to ABI-required target feature check for -Ctarget-cpu)

@jieyouxu

Rollup merge of #159833 - petrochenkov:parci, r=jieyouxu ci: Make the `x86_64-gnu-parallel-frontend` job non-optional Part of rust-lang/compiler-team#1005. Closes #118698. r? @jieyouxu

rustbot assigned jieyouxu Jul 24, 2026

jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2026

petrochenkov force-pushed the parci branch from 328edcc to d568afe Compare July 27, 2026 14:17

rustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Jul 27, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 27, 2026

jieyouxu approved these changes Jul 27, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 27, 2026

Auto merge of #159833 - petrochenkov:parci, r=<try>

7b3512f

ci: Make the `x86_64-gnu-parallel-frontend` job non-optional try-job: x86_64-gnu-parallel-frontend

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 27, 2026

petrochenkov force-pushed the parci branch from d568afe to 6a194be Compare July 27, 2026 14:51

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 27, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 27, 2026

Auto merge of #159833 - petrochenkov:parci, r=<try>

c45c6e5

ci: Make the `x86_64-gnu-parallel-frontend` job non-optional try-job: x86_64-gnu-parallel-frontend

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 27, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 27, 2026

tests/ui: Ignore one query cycle test in parallel frontend mode

960d0a5

JonathanBrouwer mentioned this pull request Jul 27, 2026

Rollup of 14 pull requests #160021

Merged

rust-bors Bot merged commit 1db2212 into rust-lang:main Jul 27, 2026
13 checks passed

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 27, 2026

rustbot added this to the 1.99.0 milestone Jul 27, 2026

rust-timer added a commit that referenced this pull request Jul 27, 2026

Unrolled build for #159833

e3f9918

Rollup merge of #159833 - petrochenkov:parci, r=jieyouxu ci: Make the `x86_64-gnu-parallel-frontend` job non-optional Part of rust-lang/compiler-team#1005. Closes #118698. r? @jieyouxu

Uh oh!

Uh oh!

Conversation

petrochenkov commented Jul 24, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 24, 2026

Uh oh!

rustbot commented Jul 24, 2026

Uh oh!

petrochenkov commented Jul 24, 2026

Announcement:

Uh oh!

Kobzol commented Jul 24, 2026

Uh oh!

jieyouxu commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Jul 27, 2026

Uh oh!

rustbot commented Jul 27, 2026

Uh oh!

rustbot commented Jul 27, 2026

Uh oh!

petrochenkov commented Jul 27, 2026

Uh oh!

jieyouxu commented Jul 27, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jul 27, 2026

Uh oh!

jieyouxu commented Jul 27, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 27, 2026

Uh oh!

rust-bors Bot commented Jul 27, 2026

Uh oh!

petrochenkov commented Jul 27, 2026

Uh oh!

This comment has been minimized.

petrochenkov commented Jul 27, 2026

Uh oh!

rust-bors Bot commented Jul 27, 2026

Uh oh!

JonathanBrouwer commented Jul 27, 2026

Uh oh!

rust-bors Bot commented Jul 27, 2026

Uh oh!

petrochenkov commented Jul 27, 2026

Uh oh!

JonathanBrouwer commented Jul 27, 2026

Uh oh!

JonathanBrouwer commented Jul 27, 2026

Uh oh!

rust-bors Bot commented Jul 27, 2026

Uh oh!

rust-bors Bot commented Jul 27, 2026

Uh oh!

rust-log-analyzer commented Jul 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

petrochenkov commented Jul 24, 2026 •

edited by rustbot

Loading

jieyouxu commented Jul 25, 2026 •

edited

Loading

jieyouxu left a comment •

edited by rustbot

Loading