Rollup of 5 pull requests - #160128
Closed
jhpratt wants to merge 11 commits into
Closed
Conversation
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Add semver check test command for checking API compatibility of stdlib This PR adds a new test to bootstrap (not executed by default at the moment) that checks the API compatibility of the standard library using the https://github.com/obi1kenobi/cargo-semver-checks tool. The command can be executed using `x test std-semver-check`. (Note: I realized that `x dist rust-docs-json` executed twice in a row invalidates Cargo cache for some reason, that is a separate issue though). The test is not yet executed on CI, I would do that in a separate PR (maybe pending a t-libs FCP or something). The test checks that c-s-c is installed, and then uses git to lookup a parent baseline commit (in a future extension, we should make the baseline commit be configurable through `config.toml`). Then it downloads the corresponding `rust-docs-json` component of that commit from CI and extracts it. It generates the same JSON docs component from local sources, and then runs c-s-c on those two JSON files to compare their API. Output when API stability is broken: ``` Checking semver compatibility of core Checking <unknown> v1.99.0-nightly (d527bc9 2026-07-20) -> v1.99.0-dev (assume minor change) Checked [ 1.282s] 196 checks: 196 pass, 57 skip Summary no semver update required Finished [ 2.368s] <unknown> Checking semver compatibility of alloc Checking <unknown> v1.99.0-nightly (d527bc9 2026-07-20) -> v1.99.0-dev (assume minor change) Checked [ 0.030s] 196 checks: 196 pass, 57 skip Summary no semver update required Finished [ 0.127s] <unknown> Checking semver compatibility of std Checking <unknown> v1.99.0-nightly (d527bc9 2026-07-20) -> v1.99.0-dev (assume minor change) Checked [ 0.055s] 196 checks: 195 pass, 1 fail, 0 warn, 57 skip --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/function_missing.ron Failed in: function std::process::id, previously in file library/std/src/process.rs:2656 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 0.243s] <unknown> ``` CC @obi1kenobi @Amanieu r? @jieyouxu
…, r=lcnr Preserve placeholder ambiguity during normalization Fixes rust-lang#159896
…ouxu Show jobs where a given test was executed in `test-dashboard` This lets us see the specific set of jobs where a given test was executed on CI. This should be quite useful e.g. for debugging where we run debuginfo tests. To test: ```bash $ cargo run --release --manifest-path src/ci/citool/Cargo.toml -- test-dashboard 008fa22 --output-dir test-dashboard ``` r? @jieyouxu
Remove various superfluous lint attributes
…ouxu add additional license option for third-party dependencies
Member
Author
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 29, 2026
Rollup of 5 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-*
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
PR #159964, which is a member of this rollup, was unapproved. This rollup was thus unapproved. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
💔 Test for e7f3407 failed: CI. Failed jobs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
test-dashboard#159994 (Show jobs where a given test was executed intest-dashboard)r? @ghost
Create a similar rollup