Skip to content

Reapply shortcuts when restoring current defaults - #1806

Merged
rxhanson merged 4 commits into
rxhanson:mainfrom
arhxam:codex/reapply-shortcut-defaults
Aug 13, 2026
Merged

Reapply shortcuts when restoring current defaults#1806
rxhanson merged 4 commits into
rxhanson:mainfrom
arhxam:codex/reapply-shortcut-defaults

Conversation

@arhxam

@arhxam arhxam commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • always reload registered shortcuts after restoring a default shortcut scheme
  • clear all active shortcut overrides before selecting the requested scheme
  • preserve the existing cancel flow and snap-area reset behavior

Fixes #1119.

Previously, selecting the already-active scheme removed persisted overrides but skipped the changeDefaults notification. The shortcut binder therefore kept stale or conflicting bindings until Rectangle restarted.

Verification

  • ShortcutDefaultsRestoreTests: 2/2 passing for same-scheme and changed-scheme resets
  • full RectangleTests: 207 tests run; the same 22 pre-existing assertions fail as on main, confined to ActiveSideSplitRatiosCooperativeTests, CooperativeCornerResizeTests, and HalfSplitCornerCalculationTests
  • git diff --check origin/main...HEAD

AI assistance

AI tooling assisted with investigation, implementation, and test generation. The final diff passed independent specification and code-quality reviews and was verified locally.

@rxhanson

rxhanson commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Thanks for contributing! All of these PRs look good, I'll just spend some time manually testing prior to merging.

@rxhanson
rxhanson merged commit 95442ca into rxhanson:main Aug 13, 2026
1 check passed
@rxhanson

Copy link
Copy Markdown
Owner

Thanks! I pulled out the test since it had a merge conflict and it's ok to not have a test for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reset to default shortcuts doesn't really apply changes before app restart

2 participants