miioprotocol: wrap unexpected responses in DeviceException#2081
Open
rytilahti wants to merge 1 commit into
Open
miioprotocol: wrap unexpected responses in DeviceException#2081rytilahti wants to merge 1 commit into
rytilahti wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2081 +/- ##
==========================================
+ Coverage 84.13% 84.16% +0.03%
==========================================
Files 199 199
Lines 20164 20170 +6
Branches 1063 1064 +1
==========================================
+ Hits 16964 16976 +12
+ Misses 3010 3002 -8
- Partials 190 192 +2 ☔ View full report in Codecov by Harness. |
3b0b40a to
3a7e326
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid leaking raw exceptions to downstreams, send() now raises PayloadDecodeException when the device response cannot be decrypted (payload is not a dict), and wraps any other unexpected exception in DeviceException.
Fixes #1913