Skip to content

fix: scope connection health refreshes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
saga-agent wants to merge 1 commit into
base: review/pr-1311-base
Choose a base branch
from
Draft

fix: scope connection health refreshes #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions packages/react/src/lib/use-connection-health.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ import { RegistryContext, useAtomSet } from "@effect/atom-react";
import * as Exit from "effect/Exit";
import type { Connection, HealthCheckResult, HealthStatus, Owner } from "@executor-js/sdk/shared";

import { checkConnectionHealth, connectionsOptimisticAtom } from "../api/atoms";
import { connectionCheckKeys } from "../api/reactivity-keys";
import { checkConnectionHealth, connectionsAllAtom, connectionsOptimisticAtom } from "../api/atoms";

/** Freshness window for automatic revalidation: a HEALTHY verdict younger
* than this renders as-is; anything else (stale, missing, or non-healthy)
Expand Down Expand Up @@ -47,13 +46,17 @@ const revalidateQuery = (
* persists every verdict on `last_health`, so after a check we must re-read the
* connection rows or a later render within the atom TTL serves the pre-check
* state. Returns a stable callback usable from a probe's `.then` for any owner
* (the loop surface probes across both owners), refreshing the optimistic atom
* every connections view derives from.
* (the loop surface probes across both owners), refreshing the owner-scoped
* optimistic atom plus the all-connections view that provider accounts derive
* from.
*/
function useInvalidateConnections(): (owner: Owner) => void {
const registry = useContext(RegistryContext);
return useCallback(
(owner: Owner) => registry.refresh(connectionsOptimisticAtom(owner)),
(owner: Owner) => {
registry.refresh(connectionsOptimisticAtom(owner));
registry.refresh(connectionsAllAtom);
},
[registry],
);
}
Expand Down Expand Up @@ -107,17 +110,19 @@ export function useConnectionHealth(connection: Connection): {
}, [connection, doCheck, invalidateConnections]);

const runCheck = useCallback(async () => {
// Manual "Check now": invalidate the connections cache unconditionally so
// every surface picks up the freshly persisted verdict. Re-running this
// effect after the refetch is harmless: the ref guard blocks a re-probe.
// Manual "Check now": refresh connection reads after folding the returned
// verdict into this row. Re-running this effect after the refetch is
// harmless: the ref guard blocks a re-probe.
const exit = await doCheck({
params: connectionParams(connection),
query: {},
reactivityKeys: connectionCheckKeys,
});
if (Exit.isSuccess(exit)) setLiveProbe(exit.value);
if (Exit.isSuccess(exit)) {
setLiveProbe(exit.value);
invalidateConnections(connection.owner);
}
return exit;
}, [connection, doCheck]);
}, [connection, doCheck, invalidateConnections]);

return { probe, status, runCheck };
}
Expand Down