Fixed issue where unused error Symbols were kept in the objective. - #3
Open
AhoyISki wants to merge 2 commits into
Open
Fixed issue where unused error Symbols were kept in the objective.#3AhoyISki wants to merge 2 commits into
AhoyISki wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, hope you're doing well.
I found a bug in the solver. Basically, if you remove constraints where both
tag.markerandtag.otherwere of typeSymbolType::Error, onlytag.markerwould get removed, even thoughtag.otherwasn't going to be used anyways. This was caused by a single usage ofelse if, whereifshould've been used instead.In my case, this lead to a blowup in the number of elements in the objective, which severely slowed down cassowary to an unusable state, even though I made sure to always clean up absolutely everything, as checked by all the other members of the
Solver, which kept the same number of elements.I've already done this pull request to the original cassowary-rs. But considering that the last activity on that repository was 7 years ago, I'm not expecting it to actually get merged.
Anyways, hopefully you get this merged, this is a pretty big issue I think.