feat: make json loader read dtypes correctly and also load small json values#72
Open
jokasimr wants to merge 2 commits into
Open
feat: make json loader read dtypes correctly and also load small json values#72jokasimr wants to merge 2 commits into
jokasimr wants to merge 2 commits into
Conversation
…on values for validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the json chexus reader loaded
typeinstead ofdtypewhich seems to be the correct field to read from the Nexus JSON templates.The json reader also didn't store any datasets, which makes sense because we don't want to run out of memory if we read large files. But that also breaks a lot of useful cases, mainly validating transformation chains.
So here I made it store only small values up to 100KB.
Unless the file has ~80K small datasets we are unlikely to run out of space with that limit.