Add HttpClient.BaseAddress Documentation - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documented the trailing slash requirement on
HttpClient.BaseAddresswhen combining it with a relative route.<remarks>blocks to all fourUsingRouteoverloads (stringandUri, generic and non-generic) explaining thatBaseAddressmust end with a trailing slash for a relative route to be appended correctly, with a worked example and a note that a leading slash on the route does not fix it.<remarks>blocks to bothUsingBaseoverloads clarifying that they don't accept or set a route, so the trailing slash requirement doesn't apply to them directly.dangeradmonition to theHttpRequestBuilderdocs page explaining the same behavior, with a link to RFC 3986 section 5.No behavior changed. This is expected
Uricombination behavior per RFC 3986, not a bug in FluentHttpClient, so the fix is documentation rather than code.Related issue
Closes #58
Type
Checklist
Notes
No tests added since no behavior changed, this is a documentation-only PR. Not a breaking change.