feat: v0.8.0#10
Draft
Thegaram wants to merge 4 commits into
Draft
Conversation
- Bump openvm-sdk/openvm-native-recursion to v1.6.0 and openvm-stark-sdk to v1.4.0 - Replace deprecated Sdk::riscv32().generate_halo2_verifier_solidity() with snark_verifier_sdk::evm::gen_evm_verifier_sol_code, matching zkvm-prover/crates/build-guest - Format re-computed Solidity with the canonical forge fmt config so solc metadata hash matches the deployed Halo2Verifier.sol - Document Foundry v1.5.0 requirement for exact --recompute codehash Both generate-verifier and generate-verifier --recompute (with forge v1.5.0) now produce the on-chain codehash 0x6a74f16c...805663.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to v0.8.0 version: scroll-tech/zkvm-prover#254 (deployed on mainnet, but not merged and tagged yet).
Verifier codehash fix
The previous
generate-verifier --recomputeimplementation was based on OpenVM v1.4.0 and produced a codehash that did not match the verifier deployed at0x96cbcC4333E172927fDa8B631C716d43E2FBA01C(0x6a74f16c472ea2698ee461daf35ffb62faaef6280d40390961daa181bc805663). This PR aligns the tool withzkvm-prover v0.8.0/ OpenVM v1.6.0:zkvm-prover v0.8.0.zkvm-prover/crates/build-guest.forge fmtconfiguration before compiling the re-computed verifier, so thesolcmetadata hash matches the publishedHalo2Verifier.sol.--recomputeto yield the exact on-chain codehash.Verification
Both modes now produce the same codehash as the on-chain verifier.