feat(proto): add RunnerService.CommitConversationFrame sink-ack RPC - #42
Merged
Conversation
sealedsecurity-bot
marked this pull request as ready for review
July 29, 2026 22:23
seal-agent
force-pushed
the
compass-repo-sink-ack-proto
branch
3 times, most recently
from
July 29, 2026 22:51
bf1cfe1 to
c45ba25
Compare
The Server-terminated half of the agent's PostConversationFrame: the Runner forwards a durable conversation frame here and gets back the sink result (committed + message_id + seq) so a durable post resolves delivered-or-erred with real coordinates, not fire-and-forget. Internal-go gen only; no public gen or TS client surface. Additive to compass.v1 (buf-breaking-safe). Co-Authored-By: seal <noreply@sealedsecurity.com>
seal-agent
force-pushed
the
compass-repo-sink-ack-proto
branch
from
July 29, 2026 22:57
c45ba25 to
7804e72
Compare
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Adds the
CommitConversationFrameunary RPC toRunnerService(proto/compass/v1/runner.proto) plus its request/response messages, and regenerates the internal-go stubs. This is T1 of the agent↔runner sink-ack seam (closes #24 OQ-3).RelayCommsCall):CommitConversationFrame(CommitConversationFrameRequest) returns (CommitConversationFrameResponse)— the Server-terminated half of the agent'sPostConversationFrame. The Runner forwards a durable conversation frame here (rather than onto the loss-tolerablePublishEventsspine) and gets back the sink result, so a durable post resolves delivered-or-erred with real coordinates instead of fire-and-forget.CommitConversationFrameRequest{ string session_id = 1; AgentFrame frame = 2; string idempotency_key = 3; }— mirrorsPostConversationFrameRequest(sameAgentFrame+ agent-mintedidempotency_keyenvelope-dedup field), plus an explicitsession_idbecause on the Runner→Server hop there is no per-container socket to carry session identity. The Runner asserts no account; the Server resolvessession_id → accountfrom its own binding, fail-closedCodeNotFound, same posture asRelayCommsCall.CommitConversationFrameResponse{ bool committed = 1; string message_id = 2; uint64 seq = 3; }— the sink ack:message_id+seqare the durable coordinates the Server'scommsConversationSink(CommitAgentPost/CommitAgentUpdate) assigns.Naming note
The response type is
...Response, not...Ack(as the seam spec sketched it):runner.protokeeps every STANDARD buf-lint rule armed, andRPC_RESPONSE_STANDARD_NAMErequires theResponsesuffix. The only existing exemption (agent_gateway.proto'sCommsCallResult) is justified by cross-hop envelope reuse, which this type does not have. The ack semantics live in the fields + doc-comment. Flagged to compass-server for confirmation.Surface / safety
runner.protogenerates solely intogo/internal/gen(viabuf.gen.internal-go.yaml); verified zero new surface ingo/gen, the TS client, or the agent gen tree, so the@compass/clientserver-door fence holds.compass/**/*.protovs main) clean — purely additive in the ownedcompass.v1package.go build ./internal/gen/...rc=0).Downstream (dogfood critical path)
Once merged: compass-server wires the Server handler (
commsConversationSink→ fillsmessage_id/seq); compass-runner swaps its downstreamPostConversationFramefrompublisher.forwardto this unary. Unblocks the C-series stack (#24 ← #38).Refs SEA-1507
Co-Authored-By: seal noreply@sealedsecurity.com