fix(metrics): Prometheus metrics output#3640
Conversation
PR SummaryLow Risk Overview Both OTel→Prometheus setup paths now use Exported labels change shape—for example Reviewed by Cursor Bugbot for commit 70d09f2. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
@philipsu522 this would be great to get into 6.6 release if possible |
|
Hi @Kbhat1 - is there a process for becoming a contributor? I'd like to get this reviewed and merged, and I'm concerned because my last PR fell by the wayside. I'm thinking the Also this is non-breaking for app hash, but I can't add that label. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3640 +/- ##
==========================================
- Coverage 59.16% 58.20% -0.96%
==========================================
Files 2263 2179 -84
Lines 187159 177514 -9645
==========================================
- Hits 110724 103330 -7394
+ Misses 66484 65028 -1456
+ Partials 9951 9156 -795
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/backport |
|
Successfully created backport PR for |
Backport of #3640 to `release/v6.6`. Co-authored-by: m3diumrare <127280934+m3diumrare@users.noreply.github.com> Co-authored-by: Philip Su <philip.su.522@gmail.com>
* main: feat(seid): ConfigManager selection seam (PLT-775 PR1) (#3671) fix(evmrpc): limit listener max open connections, configurable via max_open_connections (PLT-704) (#3637) LittDB: Keymap threading improvements (#3645) integrate hashlogger (#3647) fix(metrics): Prometheus metrics output (#3640) [codex] Harden multiversion iterator validation (#3656) feat(consensus): mock_chain_validation replay build + memIAVL state-sync restore fixes (#3663) chore: replace OLD red SeiLogo banner in README with new 2026 Sei lockup (#3670) Require absolute path for evmone lib (#3668) fix(evmrpc): apply getLogs maxLog cap during merge instead of after (PLT-687) (#3666) feat(evmrpc): pre-decode request size admission control (PLT-295) (#3648) Make autobahn block production check wait for progress (#3667) fix(sei-tendermint): prevent readRoutine goroutine leak on /websocket when writeChan is full (PLT-707) (#3664) Per-block littidx flush + single shard (gated on #3645) (#3660) fix(evmrpc): bound debug_traceStateAccess memory and add trace admission control (PLT-360) (#3653) [codex] bump go-ethereum to v1.15.7-sei-17 (#3657) Upodate checkout GHA step across all workflows (#3659) Add GoReleaser release pipeline for static seid binaries (#3425) Parallelize littidx eth_getLogs across blocks (#3652)
After the
sei-chaintosei_chainprefix change in #3554, it surfaced that otel labels also had invalid Prometheus label characters ('.')Tested on local Sei node, with this patch the Prometheus remote write endpoint no longer drops any metrics from the node.
Example before:
after: