Skip to content

[UIK-5614][date-picker] changed border-radius in calendar #3097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilyabrower wants to merge 6 commits into
base: UIK-5351/add-more-variables-to-theme
Choose a base branch
from
Open

[UIK-5614][date-picker] changed border-radius in calendar #3097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f9c8c7
[date-picker] changed border-radius in calendar
ilyabrower Jul 31, 2026
788d11e
Merge branch 'UIK-5351/add-more-variables-to-theme' into UIK-5614/dat…
Valeria-Zimnitskaya Aug 6, 2026
cf49812
[date-picker] fixed border-radius for calendar units
ilyabrower Aug 6, 2026
2bc693b
[chore] Merge branch 'UIK-5614/date-picker-redesign' of github.com:se…
ilyabrower Aug 7, 2026
dd12360
[date-picker] update snapshots
Valeria-Zimnitskaya Aug 7, 2026
81a0a2b
[date-picker] replaced margin with row gap, reduced calendar focus bo…
sheila-semrush Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...-props-and-date-picker-Verify-all-calendar-props-work-good-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...r-props-and-date-picker-Verify-all-calendar-props-work-good-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ar-props-and-date-picker-Verify-all-calendar-props-work-good-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ced-us-f1256-mouse-intearctions-and-styles-of-advanced-use-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...nced-us-f1256-mouse-intearctions-and-styles-of-advanced-use-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...anced-us-f1256-mouse-intearctions-and-styles-of-advanced-use-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...nced-u-22177-mouse-intearctions-and-styles-of-advanced-use-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...anced-u-22177-mouse-intearctions-and-styles-of-advanced-use-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...vanced-u-22177-mouse-intearctions-and-styles-of-advanced-use-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...hRangeComparator-range-Month-range-comparator-filled-state-2-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...thRangeComparator-range-Month-range-comparator-filled-state-2-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...nthRangeComparator-range-Month-range-comparator-filled-state-2-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
61 changes: 31 additions & 30 deletions semcore/date-picker/src/style/calendar.shadow.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
SCalendar {
display: flex;
flex-direction: column;
border-radius: var(--intergalactic-surface-rounded, 8px);
border-radius: var(--intergalactic-rounded-small, 4px);

@sheila-semrush sheila-semrush Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this border radius affects focus outline on the calendar in some cases, can be seen in our test story http://localhost:6006/?path=/story/components-datepicker-tests--custom-day-fixed-for-tests

gap: var(--intergalactic-spacing-content-gap-small, 4px);

@sheila-semrush sheila-semrush Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gap is visible between the mon/tue/wed row and the days


SCalendarUnit:focus-visible {
outline: none;
Expand All @@ -12,11 +13,12 @@ SGridDays {
display: grid;
grid-template-columns: repeat(7, minmax(32px, auto));
grid-template-rows: repeat(auto-fit, minmax(32px, auto));
grid-row-gap: var(--intergalactic-spacing-content-gap-small, 4px);
}

SGridMonths {
display: grid;
grid-row-gap: var(--intergalactic-spacing-2x, 8px);
grid-row-gap: var(--intergalactic-spacing-content-gap-large, 8px);
grid-template-columns: repeat(3, minmax(60px, auto));
grid-template-rows: repeat(4, minmax(32px, auto));
}
Expand Down Expand Up @@ -55,7 +57,7 @@ SCalendarUnit {
background-color: var(--intergalactic-date-picker-cell, oklch(1 0 0));

align-items: center;
border-radius: var(--intergalactic-control-rounded, 6px);
border-radius: var(--intergalactic-rounded-small, 4px);
box-sizing: border-box;
cursor: pointer;
display: flex;
Expand All @@ -67,7 +69,6 @@ SCalendarUnit {
transition: border-radius 0.15s 0.15s;
outline: none;
margin: 0;
margin-top: 4px;

@sheila-semrush sheila-semrush Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced this margin with a gap for GridDays. Month grid became tighter as a result - this is expected


&:hover {
color: var(--intergalactic-text-primary, oklch(0.1 0.03 137 / 0.899));
Expand All @@ -82,7 +83,7 @@ SCalendarUnit[today] {
display: block;
top: 1px;
left: 1px;
border-radius: var(--intergalactic-control-rounded, 6px);
border-radius: var(--intergalactic-rounded-small, 4px);
width: calc(100% - 2px);
height: calc(100% - 2px);
box-sizing: border-box;
Expand Down Expand Up @@ -124,9 +125,9 @@ SCalendarUnit[startSelected] {
background-color: var(--intergalactic-date-picker-cell-active, oklch(0.23 0.01 140));

&:not([highlighted]) {
border-bottom-left-radius: var(--intergalactic-control-rounded, 6px);
border-bottom-left-radius: var(--intergalactic-rounded-small, 4px);
border-bottom-right-radius: 0;
border-top-left-radius: var(--intergalactic-control-rounded, 6px);
border-top-left-radius: var(--intergalactic-rounded-small, 4px);
border-top-right-radius: 0;
}

Expand All @@ -142,9 +143,9 @@ SCalendarUnit[endSelected] {

&:not([highlighted]) {
border-bottom-left-radius: 0;
border-bottom-right-radius: var(--intergalactic-control-rounded, 6px);
border-bottom-right-radius: var(--intergalactic-rounded-small, 4px);
border-top-left-radius: 0;
border-top-right-radius: var(--intergalactic-control-rounded, 6px);
border-top-right-radius: var(--intergalactic-rounded-small, 4px);
}

&:hover {
Expand All @@ -154,31 +155,31 @@ SCalendarUnit[endSelected] {
}

SCalendarUnit[startHighlighted]:not([selected]) {
border-bottom-left-radius: var(--intergalactic-control-rounded, 6px);
border-bottom-left-radius: var(--intergalactic-rounded-small, 4px);
border-bottom-right-radius: 0;
border-top-left-radius: var(--intergalactic-control-rounded, 6px);
border-top-left-radius: var(--intergalactic-rounded-small, 4px);
border-top-right-radius: 0;
}

SCalendarUnit[endHighlighted]:not([selected]) {
border-bottom-left-radius: 0;
border-bottom-right-radius: var(--intergalactic-control-rounded, 6px);
border-bottom-right-radius: var(--intergalactic-rounded-small, 4px);
border-top-left-radius: 0;
border-top-right-radius: var(--intergalactic-control-rounded, 6px);
border-top-right-radius: var(--intergalactic-rounded-small, 4px);
}

SCalendarUnit[startHighlighted]SCalendarUnit[endHighlighted] {
border-bottom-left-radius: var(--intergalactic-control-rounded, 6px);
border-bottom-right-radius: var(--intergalactic-control-rounded, 6px);
border-top-left-radius: var(--intergalactic-control-rounded, 6px);
border-top-right-radius: var(--intergalactic-control-rounded, 6px);
border-bottom-left-radius: var(--intergalactic-rounded-small, 4px);
border-bottom-right-radius: var(--intergalactic-rounded-small, 4px);
border-top-left-radius: var(--intergalactic-rounded-small, 4px);
border-top-right-radius: var(--intergalactic-rounded-small, 4px);
}

SCalendarUnit[startSelected]SCalendarUnit[endSelected] {
border-bottom-left-radius: var(--intergalactic-control-rounded, 6px);
border-bottom-right-radius: var(--intergalactic-control-rounded, 6px);
border-top-left-radius: var(--intergalactic-control-rounded, 6px);
border-top-right-radius: var(--intergalactic-control-rounded, 6px);
border-bottom-left-radius: var(--intergalactic-rounded-small, 4px);
border-bottom-right-radius: var(--intergalactic-rounded-small, 4px);
border-top-left-radius: var(--intergalactic-rounded-small, 4px);
border-top-right-radius: var(--intergalactic-rounded-small, 4px);
}

SCalendarUnit[compareHighlighted] {
Expand Down Expand Up @@ -208,23 +209,23 @@ SCalendarUnit[compareEnd] {
}

SCalendarUnit[compareStartHighlighted] {
border-top-left-radius: var(--intergalactic-control-rounded, 6px);
border-bottom-left-radius: var(--intergalactic-control-rounded, 6px);
border-top-left-radius: var(--intergalactic-rounded-small, 4px);
border-bottom-left-radius: var(--intergalactic-rounded-small, 4px);
}

SCalendarUnit[compareEndHighlighted] {
border-top-right-radius: var(--intergalactic-control-rounded, 6px);
border-bottom-right-radius: var(--intergalactic-control-rounded, 6px);
border-top-right-radius: var(--intergalactic-rounded-small, 4px);
border-bottom-right-radius: var(--intergalactic-rounded-small, 4px);
}

SCalendarUnit[compareStart]:not([compareHighlighted]) {
border-top-left-radius: var(--intergalactic-control-rounded, 6px);
border-bottom-left-radius: var(--intergalactic-control-rounded, 6px);
border-top-left-radius: var(--intergalactic-rounded-small, 4px);
border-bottom-left-radius: var(--intergalactic-rounded-small, 4px);
}

SCalendarUnit[compareEnd]:not([compareHighlighted]) {
border-top-right-radius: var(--intergalactic-control-rounded, 6px);
border-bottom-right-radius: var(--intergalactic-control-rounded, 6px);
border-top-right-radius: var(--intergalactic-rounded-small, 4px);
border-bottom-right-radius: var(--intergalactic-rounded-small, 4px);
}

SCalendarUnit[outdated] {
Expand All @@ -243,7 +244,7 @@ SCalendar:focus {
}

&:not(&:has(SCalendarUnit[highlighted])) {
border-radius: var(--intergalactic-surface-rounded, 8px);
border-radius: var(--intergalactic-rounded-small, 4px);
}
}

Expand Down
6 changes: 3 additions & 3 deletions stories/components/date-picker/docs/date-picker.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import CustomDayExample from './examples/custom_day';
import CustomHeaderExample from './examples/custom_header';
import DateRangeComparatorExample from './examples/date_range_comparator';
import DateRangeComparatorAdvanceUseExample from './examples/date_range_comparator_advanced_use';
import DatepickerExample from './examples/datepicker';
import DatePickerExample from './examples/datepicker';
import DisabledDatesExample from './examples/disabled_dates';
import MonthRangeComparatorAdvanceUseExample from './examples/month_range_comparator_advanced_use';
import MonthRangePickerExample from './examples/monthrangepicker';
Expand Down Expand Up @@ -66,8 +66,8 @@ export const DateRangeComparatorAdvanceUse: StoryObj = {

};

export const Datepicker: StoryObj = {
render: DatepickerExample,
export const DatePicker: StoryObj = {
render: DatePickerExample,
play: playWrapper(DatePickerTest),
};

Expand Down
4 changes: 2 additions & 2 deletions website/docs/style/design-tokens/design-tokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3266,6 +3266,7 @@
"description": "Small gap between content elements inside controls, rows, or columns.",
"components": [
"base-trigger",
"date-picker",
"dropdown-menu",
"inline-input"
]
Expand Down Expand Up @@ -3293,6 +3294,7 @@
"components": [
"button",
"checkbox",
"date-picker",
"dropdown",
"radio",
"select"
Expand Down Expand Up @@ -3366,7 +3368,6 @@
"base-trigger",
"bulk-textarea",
"button",
"date-picker",
"dropdown-menu",
"feature-highlight",
"inline-edit",
Expand Down Expand Up @@ -3436,7 +3437,6 @@
"card",
"carousel",
"d3-chart",
"date-picker",
"feedback-form",
"notice"
]
Expand Down
Loading