Skip to content

[UIK-5667][skeleton, spin-container, spin] redesign - #3106

Open
ilyabrower wants to merge 3 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5667/spin-redesign
Open

[UIK-5667][skeleton, spin-container, spin] redesign#3106
ilyabrower wants to merge 3 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5667/spin-redesign

Conversation

@ilyabrower

@ilyabrower ilyabrower commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

sheila-semrush
sheila-semrush reviewed Aug 6, 2026
View reviewed changes
Comment thread semcore/skeleton/src/Skeleton.type.ts
type Ctx = {
gradientUrl: string;
/**
* Flag for render the Skeleton in the dark theme.

@sheila-semrush sheila-semrush Aug 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Flag for render the Skeleton in the dark theme.
* Flag for render the Skeleton on darker backgrounds.

@sheila-semrush sheila-semrush Aug 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but on the other hand, I think we agreed to just rename the themes here. Dark to invert and invert to default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment