Skip to content

[UIK-5699][link] rewrite component to NS - #3108

Open
slizhevskyv-semrush wants to merge 2 commits into
release/v17from
UIK-5699/rewrite-component-to-ns
Open

[UIK-5699][link] rewrite component to NS#3108
slizhevskyv-semrush wants to merge 2 commits into
release/v17from
UIK-5699/rewrite-component-to-ns

Conversation

@slizhevskyv-semrush

Copy link
Copy Markdown
Contributor

Changelog

@semcore/link

Changed

  • Refactor component types. Deprecated atomic types. Atomic types are part of NSLink namespace.

Motivation and Context

Refactor component types. Deprecated atomic types in favor namespaces. Nothing changed in how component works.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@github-actions github-actions Bot added the link label Aug 6, 2026
Comment thread semcore/link/src/Link.tsx Outdated
this.setState({
ariaLabelledByContent:
document.getElementById(this.asProps['aria-labelledby'])?.textContent ?? '',
document.getElementById(this.asProps['aria-labelledby'] ?? '')?.textContent ?? '',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about

const ariaLabelledBy = this.asProps['aria-labelledby'];
if (ariaLabelledBy) {
      setTimeout(() => {
        this.setState({
          ariaLabelledByContent: document.getElementById(ariaLabelledBy)?.textContent ?? '',
        });
      }, 0);
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, why not :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants