🐛 Assign presence handlers to RemoteDocPresence prototype#714
Open
alecgibson wants to merge 1 commit into
Open
🐛 Assign presence handlers to RemoteDocPresence prototype#714alecgibson wants to merge 1 commit into
RemoteDocPresence prototype#714alecgibson wants to merge 1 commit into
Conversation
Fixes #708 At the moment, `_handleCreateDel` and `_handleLoad` are assigned to `RemotePresence.prototype` rather than `RemoteDocPresence.prototype`. `RemotePresence` is the base class, and `RemoteDocPresence` is the only subclass, so these handlers still happen to be reachable via the prototype chain and the bug is invisible in practice. However, defining them on the base prototype pollutes it, and any future sibling subclass would silently inherit doc-specific presence handlers it has no business with. This change assigns both handlers to `RemoteDocPresence.prototype` where they belong. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
coverage: 97.467%. remained the same — fix-remote-doc-presence-prototype-mutation into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #708
At the moment,
_handleCreateDeland_handleLoadare assigned toRemotePresence.prototyperather thanRemoteDocPresence.prototype.RemotePresenceis the base class, andRemoteDocPresenceis the only subclass, so these handlers still happen to be reachable via the prototype chain and the bug is invisible in practice. However, defining them on the base prototype pollutes it, and any future sibling subclass would silently inherit doc-specific presence handlers it has no business with.This change assigns both handlers to
RemoteDocPresence.prototypewhere they belong.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com