Feature: emoji selector - #5
Open
ethanmoss1 wants to merge 9 commits into
Open
Conversation
Work in progress test
The is a proof of concept. It works but will need some profiling quick to ensure it is somewhat perfomant, however this is not a requirement. Will need to get some feedback first.
emoji selection has been moved over from the testing to the main file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Update Emoji Selector
This pull request updates the interactive Emoji Selector to one that utilises the inbuilt emoji selection as well as the list of aliases ntfy keeps in its repository, caching where needed.
Small spelling mistake correction has crept through also.