Skip to content

Trim overwordy semantic domain descriptions in SemDom.xml template#391

Merged
imnasnainaec merged 2 commits into
masterfrom
sem-dom-desc-trim
Jul 15, 2026
Merged

Trim overwordy semantic domain descriptions in SemDom.xml template#391
imnasnainaec merged 2 commits into
masterfrom
sem-dom-desc-trim

Conversation

@imnasnainaec

@imnasnainaec imnasnainaec commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Resolves #390

Applies to src/SIL.LCModel/Templates/SemDom.xml (the canonical FLEx new-project template) the same 12 English description trims that sillsdev/FwLocalizations#5 made to the Crowdin source (lists/LocalizableLists.xml): removing references to the removed example words, meta "add other domains" instructions, and overwordy citation passages.

Affected domains:

Domain Trim
1.5 Plant Botanical-classification citation passages
4.2.6.1.1 Card game "The example words are from…" + "Add other domains…"
4.2.6.1.2 Chess "The example words are from…" + "Add other domains…"
4.2.6.2.1 Football, soccer "The example words are from…" + "Add other domains…"
4.2.6.2.2 Basketball "The example words are from…" + "Add other domains…"
4.9.3.1 Sacred writings "Examples are only given for…"
4.9.7.1 Religious person "The examples given below are for…"
5.2.1.1 Cooking methods "An example is given below…"
5.3.4 Clothes for special occasions "Two examples are given below…"
5.3.5 Clothes for special people "Several examples are given below…"
9.2.1 Adjectives Dixon citation passage condensed
9.6.3.8 Honorifics Nahuatl citation passage removed; example condensed

Also applies the 22 punctuation/whitespace fixes from the follow-up sillsdev/FwLocalizations#7 ("Fix semantic domain punctuation and spaces"):

Fix Count Domains
Missing terminal period added to Description 8 Pain, Confession, Prosperity and Trouble, Countryside, Catch, Prevent, Symmetrical, Nicknames
Wrong terminal punctuation fixed (.?) 5 Old age; Blood money, Majority, Encourage/Incite, Nicknames (Questions)
Stray trailing space before closing tag removed 7 Insanity, Body movement, Situation/circumstances, Gnomic present, Strong (self-explanatory), Noun forms, Subordinator
Stray space before punctuation removed 2 Head ExampleWords, Sacred writings Description

The old/new strings for both sets were extracted verbatim from the respective FwLocalizations PR diffs and applied programmatically; each of the 34 old strings occurred exactly once in SemDom.xml, and the resulting texts are byte-identical to the new strings in lists/LocalizableLists.xml. Also adds a CHANGELOG entry under Unreleased.

🤖 Generated with Claude Code

Devin: https://app.devin.ai/review/sillsdev/liblcm/pull/391


This change is Reviewable

Apply the same 12 description trims made to the English source in
sillsdev/FwLocalizations#5: remove references to removed example words,
meta add-other-domain instructions, and overwordy citation passages.

Resolves #390

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@imnasnainaec imnasnainaec self-assigned this Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

LCM Tests

    16 files  ±0      16 suites  ±0   2m 44s ⏱️ -15s
 2 867 tests ±0   2 847 ✅ ±0   20 💤 ±0  0 ❌ ±0 
11 416 runs  ±0  11 248 ✅ ±0  168 💤 ±0  0 ❌ ±0 

Results for commit 430b0ee. ± Comparison against base commit 7ddecd0.

♻️ This comment has been updated with latest results.

Apply the same 22 punctuation/whitespace fixes made to the English
source in sillsdev/FwLocalizations#7: missing terminal periods, wrong
terminal punctuation (. vs ?), and stray spaces.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@imnasnainaec
imnasnainaec marked this pull request as ready for review July 15, 2026 20:01
@imnasnainaec imnasnainaec added the 🟨Medium Medium-priority PR label Jul 15, 2026

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

@imnasnainaec
imnasnainaec merged commit 065411e into master Jul 15, 2026
5 checks passed
@imnasnainaec
imnasnainaec deleted the sem-dom-desc-trim branch July 15, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟨Medium Medium-priority PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update SemDom.xml template with trimmed semantic domain descriptions

2 participants