Trim overwordy semantic domain descriptions in SemDom.xml template#391
Merged
Conversation
Apply the same 12 description trims made to the English source in sillsdev/FwLocalizations#5: remove references to removed example words, meta add-other-domain instructions, and overwordy citation passages. Resolves #390 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Apply the same 22 punctuation/whitespace fixes made to the English source in sillsdev/FwLocalizations#7: missing terminal periods, wrong terminal punctuation (. vs ?), and stray spaces. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
imnasnainaec
marked this pull request as ready for review
July 15, 2026 20:01
jasonleenaylor
approved these changes
Jul 15, 2026
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #390
Applies to
src/SIL.LCModel/Templates/SemDom.xml(the canonical FLEx new-project template) the same 12 English description trims that sillsdev/FwLocalizations#5 made to the Crowdin source (lists/LocalizableLists.xml): removing references to the removed example words, meta "add other domains" instructions, and overwordy citation passages.Affected domains:
Also applies the 22 punctuation/whitespace fixes from the follow-up sillsdev/FwLocalizations#7 ("Fix semantic domain punctuation and spaces"):
Description.↔?)ExampleWords, Sacred writingsDescriptionThe old/new strings for both sets were extracted verbatim from the respective FwLocalizations PR diffs and applied programmatically; each of the 34 old strings occurred exactly once in
SemDom.xml, and the resulting texts are byte-identical to the new strings inlists/LocalizableLists.xml. Also adds a CHANGELOG entry under Unreleased.🤖 Generated with Claude Code
Devin: https://app.devin.ai/review/sillsdev/liblcm/pull/391
This change is