Skip to content

Feature/refactor build#110

Open
tvdijen wants to merge 10 commits into
mainfrom
feature/refactor-build
Open

Feature/refactor build#110
tvdijen wants to merge 10 commits into
mainfrom
feature/refactor-build

Conversation

@tvdijen

@tvdijen tvdijen commented Jul 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #109

@tvdijen tvdijen requested a review from khlr July 4, 2026 21:24
@tvdijen

tvdijen commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

See build: https://github.com/simplesamlphp/SAML-tracer/actions/runs/28720058215
This zip-file looks fine, right? AMO can now check the usual places like composer.json and package.json

@tvdijen tvdijen mentioned this pull request Jul 4, 2026
Open
khlr
khlr requested changes Jul 6, 2026
View reviewed changes
Comment thread LICENSE
Comment thread .gitattributes Outdated
Comment thread .github/workflows/build-release.yml Outdated

- name: Copy third-party dependencies to lib/ directory
run: |
cp vendor/fredericpetit/highlightjs-composer/assets/js/highlight.min.js lib/highlight.min.js

@khlr khlr Jul 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formerly we had this in build.sh which, I think, leads to a much smaller result:
node tools/build.js xml properties http

This highlight.min.js has all grammars included which really boosts the file size. But I guess we'll just have to accept that...

@tvdijen tvdijen Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a way to do this without including the full version with all gramars.

Comment thread .github/workflows/build-release.yml
@tvdijen tvdijen force-pushed the feature/refactor-build branch 2 times, most recently from 57b4250 to 75e1af7 Compare July 6, 2026 10:55
@tvdijen tvdijen force-pushed the feature/refactor-build branch from 75e1af7 to bf190e0 Compare July 6, 2026 11:00
@tvdijen tvdijen force-pushed the feature/refactor-build branch from bf190e0 to 0367552 Compare July 6, 2026 11:48
@tvdijen

tvdijen commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@khlr I think I was able to address all your comments. Both dependencies are now in package.json, which hopefully is acceptable to AMO.
If you agree with this, I think this should be merged and released as 1.9.4.
The step to completely remove pako can then move to a new minor release, unless you think it's an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khlr khlr khlr requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

strict_min_version

2 participants

@tvdijen @khlr