[Gear] Trinket - Vashnik's Sanguine Rancor#11547
Conversation
| * concentrated_bile->base_tick_time / concentrated_bile->dot_duration; | ||
| concentrated_bile->base_td_multiplier *= role_mult( effect ); | ||
|
|
||
| auto crimson_bile = create_proc_action<generic_aoe_proc_t>( "crimson_bile", effect, 1303483 ); |
There was a problem hiding this comment.
since this effect splits damage and scales the 15% per target hit, should have the bool set for that after the spell id.
auto crimson_bile = create_proc_action<generic_aoe_proc_t>( "crimson_bile", effect, 1303483, true );
There was a problem hiding this comment.
i believe whenever the bool is not set, it is taken from the base as true? its using the generic 30% per target up to 150%
| // only erupt when the buff was consumed at max stacks, not when expired during combat end | ||
| if ( stacks < b->max_stack() ) | ||
| return; | ||
| auto n_targets = crimson_bile->target_list().size(); |
There was a problem hiding this comment.
this should use available_targets() instead, passing in the crimson bile target list as an arg so if distance targeting is enabled, it will know how many targets were actually in range.
There was a problem hiding this comment.
using
crimson_bile->set_target( b->player->target );
this will force a refresh of the target cache, which will then make the target_list call check if distance_targeting is enabled
am i correct?
2 participants
No description provided.