[Warlock] Update Demonology pet interactions

[millanzarreta]

Isolated Implosion (12.1.0 WL Demo 4pc)

Several adjustments have been made to Isolated Implosion:

• It has been tested in-game that the chance is indeed 20%, as indicated by spell data. It has also been confirmed that the RNG model used is a PRD accumulator, not Flat %. In SimC it was implemented as Flat %, therefore it is changed to PRD.

  • Log: https://www.warcraftlogs.com/reports/p6qXM2Zk71FcxnH4?fight=last&type=damage-done&source=1
  • Figure:
    

• The spell behavior and its triggers have been updated to match in-game behavior:

  • It does not trigger Demoniac: In more than 22h of testing (the log cited above), no Demonic Core gains were observed when a Wild Imp died from Isolated Implosion. This is likely a bug.
  • For Hellbent Commander, it counts as a normal Wild Imp death due to lack of energy / Power Siphon, and the same applies to Demonic Power buff stacking.
  • It does not interact with To Hell and Back: Wild Imps killed by Isolated Implosion do not summon new empowered imps through this talent. This was already implemented this way, but it has been tested again.

• A proc_t has been added for Isolated Implosion to track the total number of procs.

To Hell and Back

It has been observed that, on the 12.1.0 PTR, the behavior of To Hell and Back has changed slightly when using Implosion. Now, when an odd number of imps is imploded, the number of new empowered imps summoned is rounded up. This only affects Implosion; Power Siphon keeps the previous floor-based behavior. The behavior on the current live version, 12.0.7, remains the same as before:

Imps Imploded	Empowered Imps Summoned 12.0.7	Empowered Imps Summoned 12.1.0
1	0	1
2	1	1
3	1	2
4	2	2
5	2	3
6	3	3

Hellbent Commander

It appears that Hellbent Commander behavior has changed again since the last testing and adjustment in #11405. The new table is shown below, and the SimC code has been updated to match this new behavior. This was tested on live 12.0.7, and some quick tests on the 12.1.0 PTR seem to show the same behavior. The main changes mostly prevent demons from automatically updating the counter with +1 on arise.

The table below shows how the Hellbent Commander buff is updated for each demon on arise/demise/heartbeat:

pet	heartbeat	arise	demise	comment
main_pets	1	-	-
wild_imps_1(hog)	1	-	*	-> -2 stacks on normal/PS/II demise, -1 stacks on implosion
wild_imps_2(talents)	1	-	*	-> -1 stacks on normal/PS/II demise, ±0 stacks on implosion
dreadstalker	1	-	1
vilefiend	-	1	-
vilefiend_shadow	1	1	-
vilefiend_fire	1	1	-
tyrant	1	-	-
grimoire_imp_lord	1	-	-
grimoire_fel_ravager	1	-	-
doomguard	1	-	1
doa_demons(apex)	1	-	-
diabolist_mother	-	-	-
diabolist_pit_lord	-	-	-
diabolist_overlord	-	-	-
rampaging_demon_soul	-	-	-