Detect keyboard dismissal via window insets - #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #37.
With gesture navigation there's no back key, so when you close the keyboard using its own hide button, nothing tells us it's gone. Tapping a text field after that just moved the cursor, and the keyboard never came back.
Android doesn't report that through key events at all. There's a report about exactly this (issue 242222756) that Google closed as working-as-intended, pointing at the
ime()window inset as what you're meant to watch instead. So that's what this listens for.One thing worth not deleting later:
IME_FLAG_NO_FULLSCREEN. It looks like a cosmetic tweak, but it isn't. If the keyboard goes fullscreen, Android stops sending inset updates entirely, and since this activity is landscape-only that's exactly when it would happen. Without the flag the listener never fires at all.Tested with gesture nav and floating Gboard, plus docked and floating keyboards in landscape.