fix(ci): ship the DMG's signed staging bundle as the Sparkle enclosure - #966
Merged
Merged
Conversation
Related #957 The enclosure steps zipped SWIFT_APP_PATH — the raw swift-build output, which has no core binary, no certs, and not the final Developer ID deep signature (create-dmg.sh stages and signs a separate copy for the DMG). Notarization of that zip failed ('Invalid') on the first RC, and a Sparkle update built from it would have installed an app without a core. create-dmg.sh now exports its staged, signed bundle to signed-app-<arch>/mcpproxy.app after signing, and both workflows' enclosure steps consume that export (hard-failing if absent). Caught by the Stage 1 RC dress rehearsal (v0.54.0-rc.1), exactly as the rollout plan intended.
Deploying mcpproxy-docs with
|
| Latest commit: |
e29a154
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fd0a271f.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-sparkle-enclosure-signed.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First finding of the Stage 1 RC dress rehearsal (v0.54.0-rc.1 prerelease run failed at 'Build Sparkle enclosure' with notarization status Invalid on both arches).
Root cause: the enclosure zipped
SWIFT_APP_PATH— the rawswift-buildoutput. The shippable bundle is the onecreate-dmg.shstages (tray + core + certs) and signs with the Developer ID identity;SWIFT_APP_PATHnever gets the core or that signature. Consequences: notarization Invalid, and had it passed, a Sparkle update would have installed a coreless app.Fix:
create-dmg.shexports its staged signed bundle tosigned-app-<arch>/mcpproxy.app(verified withcodesign --verify --deep --strictat export); bothprerelease.ymlandrelease.ymlenclosure steps consume that export and hard-fail if it's missing.Verified:
bash -n, both workflows YAML-parse. Real verification is the next RC tag — which is the point of the rehearsal.Related #957
🤖 Generated with Claude Code