fix(tray): hand Sparkle the SemVer comparator + RC-channel update policy - #967
Merged
Merged
Conversation
…c.3 and stable EQUAL Related #957 SUStandardVersionComparator treats the entire prerelease suffix as noise (verified directly against Sparkle 2.9.3: 0.54.0-rc.2 vs 0.54.0-rc.3 vs 0.54.0 all compare orderedSame), so every RC-to-RC and RC-to-stable update was invisible — 'You're up to date' on a feed that plainly carried a newer item, found live on the v0.54.0-rc.3 dress rehearsal. The FR-006 SemanticVersion util existed but was never plugged into Sparkle; SemVerSparkleComparator is the missing versionComparator(for:) delegate, falling back to Sparkle's comparator only for strings that are not versions. Also, channel policy per maintainer decision: RC users update to the next RC OR the next stable, whichever is newer; stable users only ever see stables. release.yml now copies the stable feed over the beta feeds and fires a second beta-channel site dispatch, so RC users are not stranded on their last RC when a cycle ends. SemVer precedence makes the stable outrank its own RCs. Plus: Sparkle decision diagnostics (feed URL, allowed channels, loaded appcast items — the lines whose absence cost this debugging session) and the vv double-prefix fix in the supersede consent label. Verified end to end against production artifacts: a locally-built rc.2 tray with this fix detected rc.3 on the live beta feed, one-click downloaded the real enclosure, EdDSA-verified with the production key, swapped, relaunched as rc.3, and superseded the old core.
Deploying mcpproxy-docs with
|
| Latest commit: |
bcaec3c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd0b3b12.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-sparkle-semver-comparato.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second (and final) release-blocker found by the Stage 1 RC dress rehearsal.
Root cause:
SUStandardVersionComparatorreports0.54.0-rc.2,0.54.0-rc.3and0.54.0as EQUAL (verified directly against Sparkle 2.9.3) — every RC→RC and RC→stable update was invisible, producing "You're up to date" against a feed that plainly carried a newer item. The FR-006 SemVer util existed but was never handed to Sparkle.Fixes
SemVerSparkleComparator: the missingversionComparator(for:)delegate (SemVer 2.0 precedence; non-version strings fall back to Sparkle's comparator). 5 new tests.release.ymlpublishes the stable item into the beta feeds too (untagged = visible to every channel; SemVer makes stable outrank its RCs) + a second beta-channel site dispatch.vvdouble-prefix fix in the supersede consent label.Verified end-to-end with production artifacts: locally-built rc.2 tray with this fix → detected rc.3 on the live mcpproxy.app beta feed → one click → real enclosure downloaded → production-EdDSA verified → bundle swapped → relaunched as rc.3 → old core superseded (
core: v0.54.0-rc.3, launched_by: tray). Swift suite: 939 tests, 1 known-environmental failure.Related #957
🤖 Generated with Claude Code