Handle potential null query in parse_str and removes PHP deprecation warning#14
Open
MRui (mariopro) wants to merge 1 commit into
Open
Handle potential null query in parse_str and removes PHP deprecation warning#14MRui (mariopro) wants to merge 1 commit into
MRui (mariopro) wants to merge 1 commit into
Conversation
Handle PHP deprecation warning in parse_str(): Passing null to parameter snowplow-referer-parser#1 ($string) of type string is deprecated in /snowplow/referer-parser/php/src/Snowplow/RefererParser/Parser.php on line 53
|
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle PHP deprecation warning in parse_str(): Passing null to parameter #1 ($string) of type string is deprecated in /snowplow/referer-parser/php/src/Snowplow/RefererParser/Parser.php on line 53