fix: preset heat_8_15 no longer gets stuck - #478
Open
dennismdejong wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #368
Root cause: _update_attributes reassigned default_preset to PRESET_8_15 on temperature edits below 15, so plain changes could re-enter summer-house mode, and the exit path kept stale stored restore data.
Fix: only the dedicated preset flow toggles heat_8_15; _update_attributes maps eco/quiet/powerful only; stored restore data is cleared after a successful exit.
Verification: compile-only (no HA test harness in this repo).