fix: 지원자 현황 지원 대학 표시 수정#605
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Walkthrough
Estimated code review effort: 2 (Simple) | ~12 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
지원한 대학 ({n}개)형식으로 수정했습니다.logoImageUrl을 지원한 대학 카드와 지원자 현황 목록 카드에 표시하도록 반영했습니다.logoImageUrl,backgroundImageUrl이 누락되지 않도록 보강했습니다.특이 사항
/applicationsAPI는 인증이 필요해 비인증 curl에서는 401이 반환됩니다. 현재 프론트 타입에 반영된logoImageUrl/backgroundImageUrl기준으로 렌더링을 연결했습니다.리뷰 요구사항 (선택)
검증
pnpm --filter @solid-connect/web exec biome check src/app/university/application/ScoreSheet.tsx src/app/university/application/ScorePageContent.tsx 'src/app/university/application/[universityName]/ApplicationUniversityDetailContent.tsx' src/types/application.tspnpm --filter @solid-connect/web run typecheck:cici:check통과ci:check및build통과