refactor: prod RDS 리소스 제거#63
Conversation
Hexeong
requested review from
Gyuhyeok99,
lsy1307,
sukangpunch,
whqtker and
wibaek
as code owners
|
Warning Review limit reached
Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughRDS 리소스를 제거하고, DB EC2 또는 RDS 활성화 시 추가 MySQL 사용자와 권한을 생성하도록 변경했습니다. DB EC2 기본값은 비활성화되며, Stage의 RDS 비활성화 강제 설정은 제거됩니다. ChangesDB 백엔드 프로비저닝 전환
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Terraform Plan:
|
Terraform Plan:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 533d7f5ea1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| description = "RDS 사용 여부" | ||
| type = bool | ||
| default = true | ||
| default = false |
There was a problem hiding this comment.
When this default is used by prod, Terraform will destroy the prod RDS instance, but the load-test stack still starts by applying environment/load_test (scripts/load_test/start.sh runs terraform apply) and that configuration looks up var.prod_rds_identifier via data.aws_db_instance.prod and the latest automated RDS snapshot in environment/load_test/main.tf:51-58. After the prod DB instance is gone, the Load Test Start workflow can no longer resolve those data sources, so load-test provisioning fails instead of restoring from the intended source. Please migrate the load-test stack to the new DB EC2/manual snapshot source, or keep a compatible RDS source, before disabling RDS by default.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
해당 지적은 맞습니다. 하지만 현재 #61은 prod 앱 전환 완료 후 운영 RDS 삭제가 목적이고, load-test 환경은 기존에도 별도 이슈로 분리하기로 했던 영역이므로 별도 이슈에서 처리하고자 합니다!
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@modules/app_stack/db_users.tf`:
- Around line 1-23: Mark additional_db_users as sensitive by adding sensitive =
true to its variable declarations in modules/app_stack/variables.tf and
environment/prod/variables.tf, preserving the existing type, default, and
description settings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 21fdb8a8-d4f4-4563-af21-0203c1b27afc
📒 Files selected for processing (4)
environment/stage/main.tfmodules/app_stack/db_users.tfmodules/app_stack/rds.tfmodules/app_stack/variables.tf
💤 Files with no reviewable changes (2)
- environment/stage/main.tf
- modules/app_stack/rds.tf
2 participants
관련 이슈
작업 내용
enable_rds기본값을false로 변경했습니다.enable_rds = false설정을 제거했습니다.rds.tf에서db_users.tf로 분리했습니다.특이 사항
rds.tf는 남겨두었습니다. 아직 Terraform state에 prod RDS 리소스가 남아 있으므로, 파일을 바로 제거하기보다enable_rds = false를 통해 Terraform이 RDS와 RDS 보안그룹을 정상 destroy하도록 유지하는 편이 안전합니다.리뷰 요구사항 (선택)
terraform fmt -check -recursive environment/prod environment/stage modules/app_stack,git diff --check, stage/prodterraform validate, DB EC2 터널 기준 prodterraform plan확인 완료 (Plan: 0 to add, 0 to change, 2 to destroy).Summary by CodeRabbit