rtc: armada38x: disable update interrupt feature#595
Open
fountzou wants to merge 1 commit into
Open
Conversation
Stop advertising update interrupts for the armada38x RTC driver Signed-off-by: fountzou <ioannis.fountzoulas@nokia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@lizhijianrd @saiarcot895 Please help review. This is an alternate fix for the RTC issue |
paulmenzel
suggested changes
Jul 1, 2026
paulmenzel
left a comment
paulmenzel
left a comment
Contributor
There was a problem hiding this comment.
Thank you. Please send the patch upstream for review.
| @@ -0,0 +1,25 @@ | |||
| From 97dafb76ffc08cbac6bca2568e8d179d7f2f3632 Mon Sep 17 00:00:00 2001 | |||
| From: fountzou <ioannis.fountzoulas@nokia.com> | |||
Contributor
There was a problem hiding this comment.
Please use your full name.
| From: fountzou <ioannis.fountzoulas@nokia.com> | ||
| Date: Wed, 1 Jul 2026 11:50:21 -0400 | ||
| Subject: [PATCH] Clear UIE bit from armada38x RTC driver | ||
|
|
Contributor
There was a problem hiding this comment.
Please add a commit message suitable for Linux upstream. (What is the problem? How is it fixed and tested? Please also detail why the CPU hangs, and if it’s an hardware issue.)
| else | ||
| clear_bit(RTC_FEATURE_ALARM, rtc->rtc_dev->features); | ||
|
|
||
| + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtc_dev->features); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop advertising update interrupts for the armada38x RTC driver.
SONiC switched to chrony, which enables RTC update interrupts via the RTC_UIE_ON ioctl. On the armada38x RTC driver, big skew in time can lead to pinning the CPU and triggering the RCU stall and reboot.
We clear the RTC_FEATURE_UPDATE_INTERRUPT at probe time, so RTC_UIE_ON no longer takes the native periodic-timer path and instead routes to the UIE emulation path (dbd69ff).