index: surface corrupt rune and match offsets - #1108
Merged
Conversation
Malformed rune mappings previously underflowed into huge offsets, while defensive bounds checks risked turning the same corruption into an invisible non-match. Propagate the first per-document corruption error through Search so callers can distinguish incomplete results from a valid zero-match response. Note: zoekt already handles panics in search as a corrupt index, and we mark as part of the search statistics that we crashed a shard. This commit makes it so we are far more defensive.
keegancsmith
force-pushed
the
k/observable-corrupt-match-offsets
branch
from
August 7, 2026 09:35
c0392a6 to
969d417
Compare
keegancsmith
marked this pull request as ready for review
August 7, 2026 09:39
keegancsmith
enabled auto-merge (squash)
August 12, 2026 14:45
burmudar
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed rune mappings previously underflowed into huge offsets, while defensive bounds checks risked turning the same corruption into an invisible non-match. Propagate the first per-document corruption error through Search so callers can distinguish incomplete results from a valid zero-match response.
Note: zoekt already handles panics in search as a corrupt index, and we mark as part of the search statistics that we crashed a shard. This commit makes it so we are far more defensive.
This supersedes #1059 with a smaller current-main implementation and addresses the silent-zero concern in #1106 by ensuring corruption contributes a crashed-shard signal rather than a plain non-match.
Test Plan: I checked all benchmarks for regressions + got an agent to exercise this change on my local sourcecode corpus.