Multi-platform Docker builds - #1129
Open
kokes wants to merge 1 commit into
Open
Conversation
keegancsmith
left a comment
keegancsmith
left a comment
Member
There was a problem hiding this comment.
There are no CGO bits, in fact in our Dockerfile we set CGO_ENABLED=0.
I think what you are seeing is the building of universal-ctags we ship with the image. Do you have any ideas on how we could maybe share that across builds? That should change very rarely (hasn't changed in years).
Before I approve I'm interested in if you actually use ARM + zoekt or intend to? Interesting in know more :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the built image is only for platform amd64, not the somewhat widely used arm64. The sad reality here is that there look to be CGO bits, so the cross platform build is kinda slow (20 minutes as opposed to 3 minutes currently).
Not sure if we can adjust caching to speed this up, I just tried a hot run (~30 seconds) and then changed some code and was back to 20 minutes.
If this performance (albeit only on pushes to main) is unreasonably slow for you, I fully understand if you close this. Just wanted to throw it out there for your consideration.