Handle preUpdate ahead of updating material uniforms to avoid 1 frame latency#391
Open
mrxz wants to merge 1 commit into
Open
Handle preUpdate ahead of updating material uniforms to avoid 1 frame latency#391mrxz wants to merge 1 commit into
mrxz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #390
The
preUpdateflag is supposed to ensure the splat update takes place before rendering. While this was technically true, the updated splats were not used in the rendering as the relevant uniforms had already been set. This also meant that the uniforms referred to values from an accumulator that had already been released.This PR moves the
updateInternalcall to the start of theonBeforeRenderingmethod. In case ofpreUpdatethis would ensure a synchronous update before the uniforms were updated. Whereas the default case is still to schedule the update asynchronously throughsetTimeout.Note that whether or not the result of update is visible that same frame still depends on whether or not the mappings are compatible, though in simple cases like
recolorthis holds.