Introduce AbortController in PagedSplats to abort ongoing fetches#392
Open
mrxz wants to merge 1 commit into
Open
Introduce AbortController in PagedSplats to abort ongoing fetches#392mrxz wants to merge 1 commit into
mrxz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #384
Once the
SplatPagerstarted a fetcher, it would always run to completion, meaning awaiting the full network request, using the worker to decode the result and processing the fetched result all the way to uploading the result. This PR introduces anAbortControllerinPagedSplatsto signal when it is disposed. Upon disposal it willThere are still some gaps where work can be done (or attempted) for a
PagedSplatsinstance that has already been disposed. However these are very late in the process (e.g. uploading) so unlikely to gain much by adding more logic to prevent this. By far the most time is spent on the network fetch and decoding, both of which is properly covered.