bindParameter: use mp_obj_is_float() so it builds on MicroPython 1.29+#39
Open
UKTailwind wants to merge 1 commit into
Open
bindParameter: use mp_obj_is_float() so it builds on MicroPython 1.29+#39UKTailwind wants to merge 1 commit into
UKTailwind wants to merge 1 commit into
Conversation
mp_obj_is_type(v, &mp_type_float) now trips a compile-time static assert (mp_type_assert_not_float) in MicroPython 1.29, since float may be a value-encoded type. Use mp_obj_is_float() instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bindParameter()usesmp_obj_is_type(value, &mp_type_float)to detect floats. On MicroPython 1.29+ that trips a compile-time static assert (mp_type_assert_not_float):floatcan be a value-encoded type, so there is nomp_type_floatobject to compare a pointer against. The build fails.Use the portable
mp_obj_is_float(value)instead — one line, correct on both value-encoded and object floats, and equivalent on earlier versions.Builds cleanly on MicroPython 1.29+ (verified on the rp2 and unix ports).