GH-1018: Allow null secret values in SecretLeaseCreatedEvent - #1019
Open
kalayciburak wants to merge 1 commit into
Open
GH-1018: Allow null secret values in SecretLeaseCreatedEvent#1019kalayciburak wants to merge 1 commit into
kalayciburak wants to merge 1 commit into
Conversation
…dEvent Restore a null-tolerant unmodifiable copy so Map.copyOf no longer rejects Vault payloads that include null entries (for example AWS iam_user credentials with a null session_token). Signed-off-by: Burak KALAYCI <kalayciburak1996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SecretLeaseCreatedEventcurrently copies secrets withMap.copyOf, which rejects null values. Vault secret payloads can contain null entries (for example AWSiam_usercredentials with a nullsession_token), so lease create/rotate paths throwNullPointerExceptionafter Spring Vault 4.0.0.Restore the previous null-tolerant unmodifiable
LinkedHashMapcopy.SecretLeaseRotatedEventinherits the same constructor path.Fixes #1018
Test plan
./mvnw -pl spring-vault-core -Dtest=SecretLeaseCreatedEventUnitTests,SecretLeaseContainerUnitTests test(36/36 GREEN)SecretLeaseContainerUnitTestsregression suite