feat: Key the across signature cache by the borrow digest#199
Draft
BranimirTomeljak wants to merge 1 commit into
Draft
feat: Key the across signature cache by the borrow digest#199BranimirTomeljak wants to merge 1 commit into
BranimirTomeljak wants to merge 1 commit into
Conversation
|
Go Test coverage is 37.1 %\ ✨ ✨ ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A requeued non-exclusive across fill computes a fresh deadline each attempt, but the MPC signature cache was keyed by chain and deposit id only. The retry received the first attempt's signature paired with the new deadline and reverted on chain with InvalidSignature.
Deploy together with the sprinter-api change (https://github.com/sprintertech/sprinter-api/pull/1201).
Related Issue Or Context
Closes: #
How Has This Been Tested? Testing details.
Types of changes
Checklist: