Rafaator single-instance handling on a pipe-only design - #966
Merged
Conversation
The old singleton-instance mechanism combined a Mutex ownership gate and a named-pipe activation channel. The two could disagree: the mutex could still be held while the pipe listener was dead, so relaunching Bravo would time out against an owner that never answered and exit silently. Ownership is now arbitrated by the pipe itself (single server instance), so it cannot outlive the ability to answer. Split into a generic Infrastructure/SingleInstance component and a thin Host/BravoApplicationInstance that owns Bravo's naming, wire format and error reporting. Identity is WindowsIdentity.User, stable across UAC elevation and deployment channel. Also fixes found while reviewing the rewrite: listener restarts before dispatching (no longer starves later instances), a read timeout bounds each connection (a silent client can't hold the pipe forever), an oversized payload is reported instead of silently dropped, and the payload is UTF-8 instead of UTF-16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old singleton-instance mechanism combined a Mutex ownership gate and a named-pipe activation channel. The two could disagree: the mutex could still be held while the pipe listener was dead, so relaunching Bravo would time out against an owner that never answered and exit silently.
Ownership is now arbitrated by the pipe itself (single server instance), so it cannot outlive the ability to answer. Split into a generic Infrastructure/SingleInstance component and a thin Host/BravoApplicationInstance that owns Bravo's naming, wire format and error reporting. Identity is WindowsIdentity.User, stable across UAC elevation and deployment channel.
Also fixes found while reviewing the rewrite: listener restarts before dispatching (no longer starves later instances), a read timeout bounds each connection (a silent client can't hold the pipe forever), an oversized payload is reported instead of silently dropped, and the payload is UTF-8 instead of UTF-16.