Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
{
"name": "endpointCentralAllPatches",
"displayName": "Endpoint Central - All Patches",
"description": "Lists all the systems and their patch status.",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Incorrect description (copied from All Systems).

This stream lists patches (/api/1.4/patch/allpatches), but the description says it lists systems.

✏️ Suggested fix
-    "description": "Lists all the systems and their patch status.",
+    "description": "Lists all patches and their deployment status.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"description": "Lists all the systems and their patch status.",
"description": "Lists all patches and their deployment status.",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ManageEngine-EndpointCentral/dataStreams/endpointCentralAllPatches.json` at
line 4, The description for the endpointCentralAllPatches stream is copied from
All Systems and is incorrect for this patch feed. Update the JSON description
field in the endpointCentralAllPatches definition so it clearly states that this
stream lists patches from the allpatches endpoint, using the stream’s existing
name and endpoint context to locate it.

"baseDataSourceName": "httpRequestUnscoped",
"config": {
"httpMethod": "get",
"errorHandling": {
"type": "default"
},
"paging": {
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/api/1.4/patch/allpatches",
"pathToData": "message_response.allpatches",
"getArgs": [],
"headers": []
},
"metadata": [
{
"name": "platform_name",
"displayName": "OS"
},
{
"name": "s.name",
"displayName": "Criticality"
},
{
"shape": [
"date",
{
"timeZone": "Etc/UTC"
}
],
"name": "patch_released_time"
},
{
"pattern": ".*"
}
],
"providesPluginDiagnostics": true,
"timeframes": false,
"tags": [],
"defaultShaping": {
"filter": {
"multiOperation": "and",
"filters": []
},
"group": {
"by": [],
"aggregate": []
},
"sort": {
"top": 10,
"by": [
[
"missing",
"desc"
]
]
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"name": "endpointCentralAllSystems",
"displayName": "Endpoint Central - All Systems",
"description": "Lists all the systems and their patch status.",
"baseDataSourceName": "httpRequestUnscoped",
"config": {
"httpMethod": "get",
"errorHandling": {
"type": "default"
},
"paging": {
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/api/1.4/patch/allsystems",
"pathToData": "message_response.allsystems",
"getArgs": [],
"headers": []
},
"providesPluginDiagnostics": true,
"timeframes": false,
"tags": []
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"name": "endpointCentralPatchSummary",
"displayName": "Endpoint Central - Patch Summary",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove 'Endpoint Central - ' from all the data stream names - we don't need to repeat the plugin name for each one.

"description": "Provides summaries for patch module like health status summary, scan summary etc.",
"baseDataSourceName": "httpRequestUnscoped",
"config": {
"httpMethod": "get",
"errorHandling": {
"type": "default"
},
"paging": {
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/api/1.4/patch/summary",
"pathToData": "message_response.summary",
"getArgs": [],
"headers": []
},
"providesPluginDiagnostics": true,
"timeframes": false,
"tags": []
}
14 changes: 14 additions & 0 deletions ManageEngine-EndpointCentral/dataStreams/httprequestunscoped.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"name": "httprequestunscoped",
"displayName": "Queries per tenant (Segment)",
Comment thread
coderabbitai[bot] marked this conversation as resolved.
"baseDataSourceName": "httpRequestUnscoped",
"config": {
"httpMethod": "get",
"endpointPath": "",
"pathToData": "",
"expandInnerObjects": false,
"headers": [],
"getArgs": []
},
"timeframes": true
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"items": [
{
"name": "patchStatus",
"type": "dashboard"
},
{
"name": "patchVulnerabilty",
"type": "dashboard"
},
{
"name": "rebootRequired",
"type": "dashboard"
}
]
}
Loading
Loading