Skip to content

Add a jitter to logrotate#172

Merged
ske-prow[bot] merged 1 commit into
ske-v1.145from
v1.145-cherry-picks
Jun 30, 2026
Merged

Add a jitter to logrotate#172
ske-prow[bot] merged 1 commit into
ske-v1.145from
v1.145-cherry-picks

Conversation

@robinschneider

@robinschneider robinschneider commented Jun 30, 2026

Copy link
Copy Markdown
Member

How to categorize this PR?

/area logging
/kind enhancement

What this PR does / why we need it:
Currently all nodes run logrotate at 0:00 UTC at the same time, which causes high capacity utilization.
With the current configuration, it runs 144 times a day but only rotates the logs at 0:00 UTC, which is pointless.
This PR changes the it in order to run once a day with a jitter of 4 hours.

Which issue(s) this PR fixes:
ref gardener#15149

Special notes for your reviewer:

Release note:


Signed-off-by: Robin Schneider <mail@robinschneider.dev>
@ske-prow

ske-prow Bot commented Jun 30, 2026

Copy link
Copy Markdown

@robinschneider: The label(s) area/logging cannot be applied, because the repository doesn't have them.

Details

In response to this:

How to categorize this PR?

/area logging
/kind enhancement

What this PR does / why we need it:
Currently all nodes run logrotate at 0:00 UTC at the same time, which causes high capacity utilization.
With the current configuration, it runs 144 times a day but only rotates the logs at 0:00 UTC, which is pointless.
This PR changes the it in order to run once a day with a jitter of 4 hours.

Which issue(s) this PR fixes:
No issue created

Special notes for your reviewer:

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2026
@robinschneider

Copy link
Copy Markdown
Member Author

/test pull-gardener-integration

@robinschneider

Copy link
Copy Markdown
Member Author

I have run these tests locally without any issues

❯ make test-integration
curl -Lo hack/tools/bin/darwin-arm64/setup-envtest https://github.com/kubernetes-sigs/controller-runtime/releases/download/v0.23.3/setup-envtest-darwin-arm64
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 9899k  100 9899k    0     0  8913k      0  0:00:01  0:00:01 --:--:-- 8913k
chmod +x hack/tools/bin/darwin-arm64/setup-envtest
curl -sSfL https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-4 | HELM_INSTALL_DIR=hack/tools/bin/darwin-arm64 USE_SUDO=false bash -s -- --version v4.2.1
Helm v4.2.1 is available. Changing from version v3.20.2.
Downloading https://get.helm.sh/helm-v4.2.1-darwin-arm64.tar.gz
Verifying checksum... Done.
Preparing to install helm into hack/tools/bin/darwin-arm64
helm installed into hack/tools/bin/darwin-arm64/helm
> Installing envtest tools@1.33 with setup-envtest if necessary
using envtest tools installed at '/Users/schneiderro/Library/Application Support/io.kubebuilder.envtest/k8s/1.33.0-darwin-arm64'
> Integration Tests
ok      github.com/gardener/gardener/test/integration/apiserver/admissionplugins/shootvalidator 15.346s
ok      github.com/gardener/gardener/test/integration/controllermanager/bastion 25.731s
ok      github.com/gardener/gardener/test/integration/controllermanager/certificatesigningrequest       14.382s
ok      github.com/gardener/gardener/test/integration/controllermanager/cloudprofile    20.412s
ok      github.com/gardener/gardener/test/integration/controllermanager/controllerdeployment    15.555s
ok      github.com/gardener/gardener/test/integration/controllermanager/controllerregistration/controllerinstallation/seed      46.337s
ok      github.com/gardener/gardener/test/integration/controllermanager/controllerregistration/controllerinstallation/shoot     23.635s
ok      github.com/gardener/gardener/test/integration/controllermanager/controllerregistration/extensionclusterrole     19.022s
ok      github.com/gardener/gardener/test/integration/controllermanager/credentialsbinding      28.936s
ok      github.com/gardener/gardener/test/integration/controllermanager/event   26.206s
ok      github.com/gardener/gardener/test/integration/controllermanager/exposureclass   17.712s
ok      github.com/gardener/gardener/test/integration/controllermanager/gardenletlifecycle      36.720s
ok      github.com/gardener/gardener/test/integration/controllermanager/managedseedset  23.480s
ok      github.com/gardener/gardener/test/integration/controllermanager/namespacedcloudprofile  51.704s
ok      github.com/gardener/gardener/test/integration/controllermanager/project/activity        65.688s
ok      github.com/gardener/gardener/test/integration/controllermanager/project/project 64.086s
ok      github.com/gardener/gardener/test/integration/controllermanager/project/resourcequota   43.249s
ok      github.com/gardener/gardener/test/integration/controllermanager/project/stale   62.111s
ok      github.com/gardener/gardener/test/integration/controllermanager/quota   19.762s
ok      github.com/gardener/gardener/test/integration/controllermanager/secretbinding   26.879s
ok      github.com/gardener/gardener/test/integration/controllermanager/seed/backupbucketscheck 9.550s
ok      github.com/gardener/gardener/test/integration/controllermanager/seed/extensionscheck    15.404s
ok      github.com/gardener/gardener/test/integration/controllermanager/seed/reference  32.953s
ok      github.com/gardener/gardener/test/integration/controllermanager/seed/secrets    9.650s
ok      github.com/gardener/gardener/test/integration/controllermanager/shoot/conditions        19.668s
ok      github.com/gardener/gardener/test/integration/controllermanager/shoot/hibernation       11.404s
ok      github.com/gardener/gardener/test/integration/controllermanager/shoot/maintenance       95.107s
ok      github.com/gardener/gardener/test/integration/controllermanager/shoot/migration 13.137s
ok      github.com/gardener/gardener/test/integration/controllermanager/shoot/quota     20.087s
ok      github.com/gardener/gardener/test/integration/controllermanager/shoot/reference 74.604s
ok      github.com/gardener/gardener/test/integration/controllermanager/shoot/retry     7.301s
ok      github.com/gardener/gardener/test/integration/controllermanager/shoot/statuslabel       11.828s
ok      github.com/gardener/gardener/test/integration/controllermanager/shootstate      24.070s
ok      github.com/gardener/gardener/test/integration/envtest   8.055s
ok      github.com/gardener/gardener/test/integration/extensions/controller/backupbucket        27.886s
ok      github.com/gardener/gardener/test/integration/extensions/controller/backupentry 43.609s
ok      github.com/gardener/gardener/test/integration/extensions/controller/heartbeat   5.997s
ok      github.com/gardener/gardener/test/integration/extensions/webhook/certificates   9.520s
ok      github.com/gardener/gardener/test/integration/extensions/webhook/cloudprovider  22.860s
ok      github.com/gardener/gardener/test/integration/gardenlet/backupbucket    11.095s
ok      github.com/gardener/gardener/test/integration/gardenlet/backupentry     19.707s
ok      github.com/gardener/gardener/test/integration/gardenlet/bastion 12.553s
ok      github.com/gardener/gardener/test/integration/gardenlet/controllerinstallation/care     14.765s
ok      github.com/gardener/gardener/test/integration/gardenlet/controllerinstallation/controllerinstallation   30.185s
ok      github.com/gardener/gardener/test/integration/gardenlet/controllerinstallation/required 9.609s
ok      github.com/gardener/gardener/test/integration/gardenlet/gardenlet       9.386s
ok      github.com/gardener/gardener/test/integration/gardenlet/managedseed     10.045s
ok      github.com/gardener/gardener/test/integration/gardenlet/networkpolicy   50.828s
ok      github.com/gardener/gardener/test/integration/gardenlet/seed/care       18.236s
ok      github.com/gardener/gardener/test/integration/gardenlet/seed/lease      21.063s
ok      github.com/gardener/gardener/test/integration/gardenlet/seed/seed       80.232s
ok      github.com/gardener/gardener/test/integration/gardenlet/shoot/care      23.842s
ok      github.com/gardener/gardener/test/integration/gardenlet/shoot/lease     21.617s
ok      github.com/gardener/gardener/test/integration/gardenlet/shoot/state     44.021s
ok      github.com/gardener/gardener/test/integration/gardenlet/shoot/status    18.285s
ok      github.com/gardener/gardener/test/integration/gardenlet/tokenrequestor/workloadidentity 16.339s
ok      github.com/gardener/gardener/test/integration/gardenlet/vpaevictionrequirements 11.168s
ok      github.com/gardener/gardener/test/integration/nodeagent/certificate     13.689s
ok      github.com/gardener/gardener/test/integration/nodeagent/healthcheck     10.650s
ok      github.com/gardener/gardener/test/integration/nodeagent/lease   11.074s
ok      github.com/gardener/gardener/test/integration/nodeagent/node    10.280s
ok      github.com/gardener/gardener/test/integration/nodeagent/operatingsystemconfig   55.280s
ok      github.com/gardener/gardener/test/integration/nodeagent/systemdunitcheck        24.215s
ok      github.com/gardener/gardener/test/integration/nodeagent/token   12.045s
ok      github.com/gardener/gardener/test/integration/operator/controllerregistrar      17.131s
ok      github.com/gardener/gardener/test/integration/operator/extension/care   10.244s
ok      github.com/gardener/gardener/test/integration/operator/extension/extension      18.870s
ok      github.com/gardener/gardener/test/integration/operator/extension/required/runtime       16.971s
ok      github.com/gardener/gardener/test/integration/operator/extension/required/virtual       31.662s
ok      github.com/gardener/gardener/test/integration/operator/garden/care      17.743s
ok      github.com/gardener/gardener/test/integration/operator/garden/garden    23.387s
ok      github.com/gardener/gardener/test/integration/operator/garden/reference 15.380s
ok      github.com/gardener/gardener/test/integration/operator/gardenlet        19.661s
ok      github.com/gardener/gardener/test/integration/operator/virtual/access   25.987s
ok      github.com/gardener/gardener/test/integration/operator/virtual/cluster  8.192s
ok      github.com/gardener/gardener/test/integration/resourcemanager/crddeletionprotection     13.910s
ok      github.com/gardener/gardener/test/integration/resourcemanager/csrapprover       16.455s
ok      github.com/gardener/gardener/test/integration/resourcemanager/garbagecollector  8.088s
ok      github.com/gardener/gardener/test/integration/resourcemanager/health    41.421s
ok      github.com/gardener/gardener/test/integration/resourcemanager/highavailabilityconfig    18.860s
ok      github.com/gardener/gardener/test/integration/resourcemanager/istioclusterconfiguration 13.021s
ok      github.com/gardener/gardener/test/integration/resourcemanager/kubernetesservicehost     5.724s
ok      github.com/gardener/gardener/test/integration/resourcemanager/managedresource   92.697s
ok      github.com/gardener/gardener/test/integration/resourcemanager/networkpolicy     112.693s
ok      github.com/gardener/gardener/test/integration/resourcemanager/node/agentreconciliationdelay     10.650s
ok      github.com/gardener/gardener/test/integration/resourcemanager/node/criticalcomponents   26.202s
ok      github.com/gardener/gardener/test/integration/resourcemanager/node/highavailabilityconfig       6.166s
ok      github.com/gardener/gardener/test/integration/resourcemanager/nodeagentauthorizer       9.889s
ok      github.com/gardener/gardener/test/integration/resourcemanager/podkubeapiserverloadbalancing     5.422s
ok      github.com/gardener/gardener/test/integration/resourcemanager/podschedulername  4.954s
ok      github.com/gardener/gardener/test/integration/resourcemanager/podtopologyspreadconstraints      4.735s
ok      github.com/gardener/gardener/test/integration/resourcemanager/seccompprofile    4.866s
ok      github.com/gardener/gardener/test/integration/resourcemanager/systemcomponentsconfig    5.905s
ok      github.com/gardener/gardener/test/integration/resourcemanager/tokenrequestor    25.880s
ok      github.com/gardener/gardener/test/integration/resourcemanager/vpainplaceupdates 7.493s
ok      github.com/gardener/gardener/test/integration/scheduler/shoot   50.921s

@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2026
@ske-prow

ske-prow Bot commented Jun 30, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 77376d243e21d90cc1d89bb53a2bc175037552cd

@ske-prow

ske-prow Bot commented Jun 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2026
@ske-prow ske-prow Bot merged commit e1e99ae into ske-v1.145 Jun 30, 2026
5 checks passed
@ske-prow ske-prow Bot deleted the v1.145-cherry-picks branch June 30, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants